Update Kimi family model capabilities to match BYOK models#324814
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the isKimiFamily model detection so that Kimi capability overrides also apply to BYOK (bring-your-own-key) model identifiers that include a provider prefix (e.g. moonshot/kimi-k2.7-code). Previously isKimiFamily used startsWith, which only matched bare family names like kimi-k2.7-code and missed provider-namespaced IDs. This ensures Kimi models routed through BYOK get the same edit-tool capabilities (replace-string tools, no apply-patch) as the built-in models.
Changes:
- Switched the internal matcher in
isKimiFamilyfromstartsWithtoincludesforkimi-k2.6andkimi-k2.7-code. - Added test cases covering
moonshot/-prefixed Kimi IDs and fixed a comment indentation in the test file.
Show a summary per file
| File | Description |
|---|---|
extensions/copilot/src/platform/endpoint/common/chatModelCapabilities.ts |
Broadens isKimiFamily matching to substring so provider-prefixed BYOK IDs are detected. |
extensions/copilot/src/platform/endpoint/test/node/chatModelCapabilities.spec.ts |
Adds moonshot/kimi-* cases to the capability test and fixes a comment indentation. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Medium
lramos15
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.