Fix tunnelProtocol context key always resolving to https on focus#325445
Merged
alexr00 merged 3 commits intoJul 14, 2026
Conversation
alexr00
approved these changes
Jul 13, 2026
lramos15
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Ports view,
onFocusChangedsets thetunnelProtocolcontext key with a ternary whose branches are bothTunnelProtocol.Https, so the key reports https for every focused tunnel regardless of its actual protocol:This looks like a typo introduced in a414bf2 when the protocol handling was reworked. The context menu path (
onContextMenu) sets the key fromnode.protocoldirectly, so right-click menus behave, but anything that readstunnelProtocolafter a plain focus or selection change (keybinding and menu when clauses, the HTTP/HTTPS toggle state in the Change Port Protocol submenu) sees https even for HTTP tunnels.The fix makes the else branch return
TunnelProtocol.Http, which matches the key's declared default and the intent of the original normalization.