Replace automation dialog isolation picker with checkbox - #325887
Draft
benvillalobos wants to merge 1 commit into
Draft
Replace automation dialog isolation picker with checkbox#325887benvillalobos wants to merge 1 commit into
benvillalobos wants to merge 1 commit into
Conversation
Replaces the isolation mode dropdown with a checkbox + branch picker, matching the new-session IsolationPicker/PickerActionViewItem pattern: - Skip super.render() to avoid container-level mousedown/focus handlers - Suppress outline on container (matching PickerActionViewItem) - Use .sessions-chat-picker-slot.sessions-chat-isolation-checkbox with .action-label row, Gesture+Tap handlers, and disabled guard - Checkbox size 14 with defaultCheckboxStyles - Disable checkbox until git repo is loaded (branches available) - Add pointer-events: none to .sessions-chat-picker-slot.disabled in CSS - Remove dead isolation chip CSS - Label: 'New Worktree' Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Jul 15, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Reuses the shared branch picker in the Automation dialog and replaces the isolation-mode picker with a worktree checkbox.
Changes:
- Adds checkbox-based isolation selection.
- Uses
GitBranchPickerModelandBranchPicker. - Updates disabled and compact toolbar styling.
Show a summary per file
| File | Description |
|---|---|
aiCustomizationManagement.css |
Updates automation picker layout and divider styling. |
chatWidget.css |
Disables pointer interaction for disabled picker slots. |
automationDialog.ts |
Integrates the shared branch picker and worktree checkbox. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 3
- Review effort level: Medium
| } | ||
|
|
||
| const branchPickerModelObs = constObservable(branchPickerModel); | ||
| const branchPicker = this.renderDisposables.add(this.instantiationService.createInstance(BranchPicker, branchPickerModelObs)); |
Comment on lines
+2897
to
+2898
| margin-left: 4px; | ||
| box-shadow: -4px 0 0 -3px var(--vscode-editorWidget-border); |
Comment on lines
+2893
to
+2895
| /* Mirror the new-session `|` divider between the checkbox and branch picker: | ||
| * `box-shadow: -5px 0 0 -4px var(--vscode-editorWidget-border)` paints | ||
| * a 1px-wide bar in the gap to the chip's left. */ | ||
| * a 1px-wide bar in the gap to the slot's left. */ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 3 (final part) in a wave of PRs to make BranchPicker reusable across surfaces without requiring a session object.
#325712 decouples the branch picker from requiring a session to exist
#325886 creates a general class that implements the branch picking / loading / switching behavior implemented in CopilotChatSessionsProvider
This PR brings in the
GitBranchPickerModelintroduced in #325886, which allows the AutomationDialog to reuse the shared branch picker between the NewChatWidget and other consumers.Recording.2026-07-14.172924.mp4