align chat settings to picker name + migrate autoApprove to allowAll - #326288
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns chat permission settings with picker terminology while translating user-facing allowAll values to Agent Host’s internal autoApprove.
Changes:
- Renames the Assisted permissions feature setting and migrates its value.
- Migrates default approval configuration from
autoApprovetoallowAll. - Updates providers, pickers, tests, and documentation.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/test/common/constants.test.ts |
Tests permission-value translation. |
src/vs/workbench/contrib/chat/test/browser/agentSessions/agentHostChatInputPicker.test.ts |
Updates picker visibility tests. |
src/vs/workbench/contrib/chat/common/constants.ts |
Defines and maps default permission values. |
src/vs/workbench/contrib/chat/common/agentHostConfigPolicy.ts |
Renames Assisted permissions helpers. |
src/vs/workbench/contrib/chat/browser/chat.shared.contribution.ts |
Registers settings and migrations. |
src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostUntitledProvisionalSessionService.ts |
Maps defaults for provisional sessions. |
src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostChatInputPicker.ts |
Uses renamed visibility configuration. |
src/vs/sessions/SESSIONS.md |
Documents default permission values. |
src/vs/sessions/contrib/providers/agentHost/test/browser/localAgentHostSessionsProvider.test.ts |
Updates provider configuration tests. |
src/vs/sessions/contrib/providers/agentHost/test/browser/agentHost/agentHostPermissionPickerDelegate.test.ts |
Updates delegate setting tests. |
src/vs/sessions/contrib/providers/agentHost/browser/baseAgentHostSessionsProvider.ts |
Normalizes user-facing permission defaults. |
src/vs/sessions/contrib/providers/agentHost/browser/agentHostPermissionPickerDelegate.ts |
Uses renamed Assisted permissions helpers. |
Review details
- Files reviewed: 12/12 changed files
- Comments generated: 2
- Review effort level: Medium
justschen
marked this pull request as ready for review
July 17, 2026 06:22
justschen
enabled auto-merge (squash)
July 17, 2026 06:22
aeschli
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.