Skip to content

Preserve localized casing in panel tabs - #326851

Draft
hawkticehurst with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-panel-tabs-capitalization
Draft

Preserve localized casing in panel tabs#326851
hawkticehurst with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-panel-tabs-capitalization

Conversation

Copilot AI commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Modern UI forced title casing on panel tabs, corrupting locale-authored capitalization such as Console de débogage.

Changes

  • Preserve localized casing for panel and composite bar labels.
  • Retain the modern UI font-size override.

Panel tab capitalization regression

Verification steps

  1. Enable workbench.experimental.modernUI.
  2. Switch to French and open the panel.
  3. Confirm the tab reads Console de débogage.

Copilot AI requested review from Copilot and removed request for Copilot July 21, 2026 18:00
Copilot AI linked an issue Jul 21, 2026 that may be closed by this pull request
Co-authored-by: hawkticehurst <39639992+hawkticehurst@users.noreply.github.com>
Copilot AI requested review from Copilot and removed request for Copilot July 21, 2026 18:06
Copilot AI changed the title [WIP] Fix capitalization issue in panel tabs Preserve localized casing in panel tabs Jul 21, 2026
Copilot AI requested a review from hawkticehurst July 21, 2026 18:08
@alex-kinokon

alex-kinokon commented Jul 22, 2026

Copy link
Copy Markdown

Don’t really think this is the right fix. text-transform: capitalize; is inherently locale unaware and generally shouldn’t be used. As an example, .notifications-center-header-title is still “Aucune Nouvelle Notification” after the current patch.

@hawkticehurst

Copy link
Copy Markdown
Member

Don’t really think this is the right fix. text-transform: capitalize; is inherently locale unaware and generally shouldn’t be used. As an example, .notifications-center-header-title is still “Aucune Nouvelle Notification” after the current patch.

Nice thank you for already checking the patch! I kicked off a cloud agent to do a first draft implementation the other day but hadn't gotten around to looking at what it came up with until now. I'll dive in deeper to find a solution that's a bit more robust.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Separates panel/composite tab typography from casing rules to preserve localized labels while retaining modern UI sizing.

Changes:

  • Removes composite labels from the capitalization rule.
  • Keeps their font-size override in a dedicated rule.

Comment thread src/vs/workbench/contrib/styleOverrides/browser/media/fontRamp.css
Co-authored-by: hawkticehurst <39639992+hawkticehurst@users.noreply.github.com>

Copilot AI commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

Don’t really think this is the right fix. text-transform: capitalize; is inherently locale unaware and generally shouldn’t be used. As an example, .notifications-center-header-title is still �...

Thanks for the feedback. I replaced the capitalize override with text-transform: none so localized source casing is preserved, including the notifications-center title. Panel/composite labels now explicitly reset the inherited uppercase transform as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression: Panel tabs use wrong capitalization

4 participants