agentHost: Respect disabled AI features - #326902
Merged
Merged
Conversation
(Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
This PR updates Agent Host enablement so that disabling AI features (chat.disableAIFeatures) also disables Agent Host startup and related UI gating, and adds regression coverage for the service + context key.
Changes:
- Extend Agent Host enablement decision to account for
chat.disableAIFeatures. - Update enablement/context-key wording to reflect “features enabled” rather than “process enabled”.
- Add a browser test covering enablement + context key behavior across key config combinations.
Show a summary per file
| File | Description |
|---|---|
| src/vs/platform/agentHost/browser/agentHostEnablementService.ts | Adds chat.disableAIFeatures to the enablement boolean used to gate Agent Host behavior and context key. |
| src/vs/platform/agentHost/common/agentHostEnablementService.ts | Updates public-facing docs/strings to reflect new “features enabled” semantics. |
| src/vs/platform/agentHost/test/browser/agentHostEnablementService.test.ts | Adds regression tests verifying enablement + context key values for relevant config scenarios. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Low
(Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
(Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Track live per-window Agent Host enablement, tear down dependent registrations, and stop the shared process after the last enabled client disconnects. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
(Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove live process teardown and defer Agent Host enablement until window-scoped workspace configuration has been restored. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
(Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ures-disable-flag-review
roblourens
marked this pull request as ready for review
July 25, 2026 01:37
roblourens
enabled auto-merge (squash)
July 25, 2026 01:37
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @deepak1556Matched files:
|
A direct workspace-scoped startup test confirms that checking chat.disableAIFeatures is sufficient without changing service instantiation timing. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jruales
previously approved these changes
Jul 25, 2026
roblourens
marked this pull request as draft
July 25, 2026 01:55
auto-merge was automatically disabled
July 25, 2026 01:55
Pull request was converted to draft
(Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
roblourens
marked this pull request as ready for review
July 25, 2026 02:00
roblourens
enabled auto-merge (squash)
July 25, 2026 02:00
jruales
approved these changes
Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #326634
Summary
chat.disableAIFeaturesin the central Agent Host startup enablement decisionValidation
npm run precommit.vscode/settings.jsonwhile the service remained Eager:chat.disableAIFeatures: true→ Agent Host process not spawnedchat.disableAIFeatures: false→ Agent Host process spawned(Written by Copilot)