Skip to content

fix: memory leak in chatInputPart #327157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Simon Siefke (SimonSiefke) wants to merge 3 commits into
base: main
Choose a base branch
from
+19 −15
Open

fix: memory leak in chatInputPart #327157

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc4b1d3
dispose chat carousel listeners
SimonSiefke Jul 23, 2026
60fce71
Merge remote-tracking branch 'origin/main' into fix/memory-leak-chatI…
SimonSiefke Jul 24, 2026
ab1312a
Merge remote-tracking branch 'upstream/main' into fix/memory-leak-cha…
SimonSiefke Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 19 additions & 15 deletions src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import { Emitter, Event } from '../../../../../../base/common/event.js';
import { Iterable } from '../../../../../../base/common/iterator.js';
import { KeyCode } from '../../../../../../base/common/keyCodes.js';
import { Lazy } from '../../../../../../base/common/lazy.js';
import { Disposable, DisposableMap, DisposableStore, IDisposable, MutableDisposable, toDisposable } from '../../../../../../base/common/lifecycle.js';
import { combinedDisposable, Disposable, DisposableMap, DisposableStore, IDisposable, MutableDisposable, toDisposable } from '../../../../../../base/common/lifecycle.js';
import { ResourceSet } from '../../../../../../base/common/map.js';
import { MarshalledId } from '../../../../../../base/common/marshallingIds.js';
import { Schemas } from '../../../../../../base/common/network.js';
Expand Down Expand Up @@ -312,6 +312,10 @@ const emptyInputAttachments = observableMemento<readonly IChatRequestVariableEnt
fromStorage: deserializeUntitledInputAttachments,
});

interface IChatToolConfirmationCarouselEntry extends IDisposable {
readonly part: ChatToolConfirmationCarouselPart;
}

export class ChatInputPart extends Disposable implements IHistoryNavigationWidget {
private static _counter = 0;

Expand All @@ -326,7 +330,7 @@ export class ChatInputPart extends Disposable implements IHistoryNavigationWidge
private readonly _chatPlanReviewWidgets = this._register(new DisposableMap<string, ChatPlanReviewPart>());
private readonly _planReviewResponseIds = new Map<string, string>();
private readonly _planReviewSessionResources = new Map<string, URI>();
private readonly _chatToolConfirmationCarousels = this._register(new DisposableMap<string, ChatToolConfirmationCarouselPart>());
private readonly _chatToolConfirmationCarousels = this._register(new DisposableMap<string, IChatToolConfirmationCarouselEntry>());
private readonly _onDidChangeActiveConfirmationSubagent = this._register(new Emitter<string | undefined>());
readonly onDidChangeActiveConfirmationSubagent = this._onDidChangeActiveConfirmationSubagent.event;
private readonly _chatEditingTodosDisposables = this._register(new DisposableStore());
Expand Down Expand Up @@ -3965,7 +3969,7 @@ export class ChatInputPart extends Disposable implements IHistoryNavigationWidge

private get _currentToolConfirmationCarousel(): ChatToolConfirmationCarouselPart | undefined {
const key = this._currentSessionKey;
return key ? this._chatToolConfirmationCarousels.get(key) : undefined;
return key ? this._chatToolConfirmationCarousels.get(key)?.part : undefined;
}

renderToolConfirmationCarousel(tool: IChatToolInvocation, factory: ToolInvocationPartFactory, subAgentInvocationId?: string, agentName?: string, revealSubagent?: RevealSubagentCallback, revealSubagentLabel?: string, toolPart?: ChatToolInvocationPart): ChatToolConfirmationCarouselPart {
Expand All @@ -3983,28 +3987,28 @@ export class ChatInputPart extends Disposable implements IHistoryNavigationWidge

const part = new ChatToolConfirmationCarouselPart(factory, [], revealSubagent, revealSubagentLabel, subAgentInvocationId, agentName);
part.addToolInvocation(tool, subAgentInvocationId, agentName, revealSubagent, revealSubagentLabel, toolPart);
this._chatToolConfirmationCarousels.set(key, part);
const capturedKey = key;
this._register(part.onDidChangeActiveSubagent(id => {
const activeSubagentListener = part.onDidChangeActiveSubagent(id => {
if (this._currentSessionKey === capturedKey) {
this._onDidChangeActiveConfirmationSubagent.fire(id);
}
}));
if (this._currentSessionKey === capturedKey) {
this._onDidChangeActiveConfirmationSubagent.fire(part.activeSubAgentInvocationId);
}
dom.append(this.chatToolConfirmationCarouselContainer, part.domNode);
dom.show(this.chatToolConfirmationCarouselContainer);
this.updateToolConfirmationCarouselMaxHeight();

this._register(Event.once(part.onDidEmpty)(() => {
});
const emptyListener = Event.once(part.onDidEmpty)(() => {
this._chatToolConfirmationCarousels.deleteAndDispose(capturedKey);
if (this._currentSessionKey === capturedKey) {
this._onDidChangeActiveConfirmationSubagent.fire(undefined);
dom.clearNode(this.chatToolConfirmationCarouselContainer);
dom.hide(this.chatToolConfirmationCarouselContainer);
}
}));
});
const disposable = combinedDisposable(part, activeSubagentListener, emptyListener);
this._chatToolConfirmationCarousels.set(key, { part, dispose: () => disposable.dispose() });
if (this._currentSessionKey === capturedKey) {
this._onDidChangeActiveConfirmationSubagent.fire(part.activeSubAgentInvocationId);
}
dom.append(this.chatToolConfirmationCarouselContainer, part.domNode);
dom.show(this.chatToolConfirmationCarouselContainer);
this.updateToolConfirmationCarouselMaxHeight();

return part;
}
Expand Down