Fix Agents composer CSS specificity - #328016
Open
Henning Dieterichs (hediet) wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Makes Agents composer styling deterministic regardless of stylesheet order.
Changes:
- Strengthens contextual composer and toolbar selectors.
- Ensures embedded chat editors receive the correct background.
- Documents non-obvious cascade relationships.
Show a summary per file
| File | Description |
|---|---|
chat.css |
Strengthens embedded chat input background rules. |
sessionBackgroundActivitiesControl.css |
Preserves compact activity icon sizing. |
newChatInSession.css |
Prioritizes in-session composer overrides. |
chatView.css |
Preserves Agents-specific editor backgrounds. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Medium
Comment on lines
+1835
to
+1836
| .interactive-session .interactive-input-part .chat-input-container .chat-editor-container .interactive-input-editor .monaco-editor, | ||
| .interactive-session .interactive-input-part .chat-input-container .chat-editor-container .interactive-input-editor .monaco-editor .monaco-editor-background { |
Contributor
Screenshot ChangesBase: Changed (8)1 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details. |
Don Jayamanne (DonJayamanne)
approved these changes
Jul 29, 2026
Anthony Kim (anthonykim1)
approved these changes
Jul 29, 2026
Anthony Kim (anthonykim1)
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make Agents composer styling independent of stylesheet order by giving contextual owners enough specificity to beat generic workbench and chat rules.
The native new-session composer now consistently uses its explicit in-session toolbar overrides. This intentionally collapses the generic empty 28px bottom toolbar; the same appearance previously occurred only when stylesheets were reversed. The other composer fixtures preserve their normal-order appearance.
Cascade conflicts
.new-chat-in-session .new-chat-widget-container .new-chat-bottom-container.new-chat-widget-container .new-chat-bottom-containermax-width,padding,min-height,gap.new-chat-in-session .new-chat-widget-container .new-chat-bottom-container .action-label.new-chat-widget-container .new-chat-bottom-container .action-labelheight,padding,font-size.session-background-activities .session-background-activities-button .codicon[class*='codicon-'].monaco-workbench .codicon[class*='codicon-']font-size.interactive-session .interactive-input-part .chat-input-container … .monaco-editor.monaco-workbench .part.auxiliarybar > .content .monaco-editorbackground-color.agent-sessions-workbench .interactive-session .interactive-input-part .chat-input-container … .monaco-editorbackground-colorInline comments record each non-obvious specificity relationship next to the affected rule.
Validation