Skip to content

Add xAI model provider icon - #328413

Merged
Giuspepe merged 3 commits into
mainfrom
agents/fix-vscode-issue-8658-and-codicons
Jul 31, 2026
Merged

Add xAI model provider icon#328413
Giuspepe merged 3 commits into
mainfrom
agents/fix-vscode-issue-8658-and-codicons

Conversation

@Giuspepe

@Giuspepe Giuspepe commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Summary

  • update @vscode/codicons to 0.0.46-28 for the updated Moonshot AI glyph and new xAI glyph
  • register the xAI codicon and use it for Grok/xAI models, including BYOK models
  • avoid applying Copilot branding to unknown third-party models solely because they are hosted by the Copilot provider
  • add model provider icon coverage for Copilot-hosted Grok, agent-host Grok, BYOK xAI, and generic DeepSeek models

Fixes https://github.com/microsoft/vscode-internalbacklog/issues/8658
Depends on microsoft/vscode-codicons#506.

Validation

  • npm run compile
  • ./scripts/test.sh --grep ModelProviderIcons — 2 passing
  • launch-skill verification with the published codicons package:
    • selected live Grok 4.5 and verified chat-model-provider-xai renders U+ECEC
    • selected live Kimi K3 and verified the updated chat-model-provider-kimi glyph renders

Copilot AI review requested due to automatic review settings July 31, 2026 13:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds xAI branding for Grok models and updates the bundled Codicons dependency.

Changes:

  • Registers the new xAI codicon.
  • Assigns provider icons for Grok/xAI and generic third-party models.
  • Expands model-provider icon tests.
Show a summary per file
File Description
modelProviderIcons.test.ts Adds provider-icon coverage.
modelProviderIcons.ts Adds xAI icon selection and refines Copilot branding.
codiconsLibrary.ts Registers the xAI glyph.
remote/web/package.json Updates the remote-web Codicons dependency.
remote/web/package-lock.json Locks the updated remote-web dependency.
package.json Updates the root Codicons dependency.
package-lock.json Locks the updated root dependency.

Review details

Files not reviewed (1)
  • remote/web/package-lock.json: Generated file
  • Files reviewed: 5/7 changed files
  • Comments generated: 1
  • Review effort level: Balanced

@Giuspepe
Giuspepe marked this pull request as ready for review July 31, 2026 13:21
@Giuspepe
Giuspepe enabled auto-merge (squash) July 31, 2026 13:21
@Giuspepe Giuspepe closed this Jul 31, 2026
auto-merge was automatically disabled July 31, 2026 14:06

Pull request was closed

@Giuspepe Giuspepe reopened this Jul 31, 2026
@Giuspepe
Giuspepe merged commit 4b2897c into main Jul 31, 2026
55 checks passed
@Giuspepe
Giuspepe deleted the agents/fix-vscode-issue-8658-and-codicons branch July 31, 2026 15:02
@vs-code-engineering vs-code-engineering Bot added this to the 1.132.0 milestone Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants