don't collapse thinking/tool content - #328640
Draft
justschen wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an experimental scrolling thinking style that keeps grouped tool calls visible while collapsing completed reasoning.
Changes:
- Adds and registers
ThinkingDisplayMode.Scrolling. - Separates reasoning and tool groups, forcing eligible tools into always-visible groups.
- Adds styling and tests for scrolling-mode behavior.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/common/constants.ts |
Defines the scrolling mode. |
src/vs/workbench/contrib/chat/browser/chat.shared.contribution.ts |
Registers the experimental setting option. |
src/vs/workbench/contrib/chat/browser/widget/chatWidget.ts |
Recognizes the mode for telemetry. |
src/vs/workbench/contrib/chat/browser/widget/chatListRenderer.ts |
Implements grouping and finalization behavior. |
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatThinkingContentPart.ts |
Keeps tool groups visible and collapses completed reasoning. |
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/media/chatThinkingContent.css |
Styles headerless tool groups. |
src/vs/workbench/contrib/chat/browser/agentSessions/media/agentSessionHoverWidget.css |
Adjusts tool-group layout in session hovers. |
src/vs/workbench/contrib/chat/test/browser/widget/chatListRenderer.test.ts |
Tests mode-specific grouping decisions. |
src/vs/workbench/contrib/chat/test/browser/widget/chatContentParts/chatThinkingContentPart.test.ts |
Tests scrolling-mode visibility and collapse behavior. |
Review details
- Files reviewed: 9/9 changed files
- Comments generated: 0
- Review effort level: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.