Skip to content

Remove Automations section from AI Customizations editor - #328654

Merged
benvillalobos merged 18 commits into
mainfrom
bv/remove-automations-from-customizations-editor
Aug 3, 2026
Merged

Remove Automations section from AI Customizations editor#328654
benvillalobos merged 18 commits into
mainfrom
bv/remove-automations-from-customizations-editor

Conversation

@benvillalobos

@benvillalobos benvillalobos commented Aug 3, 2026

Copy link
Copy Markdown
Member

The Automations UX has been reworked into a dedicated custom view in the sessions sidebar. This PR removes the old Automations widget and all its touchpoints from the AI Customizations Management Editor.

Changes

  • Deleted the Automations list widget, its accessibility help provider, and their tests

  • Removed Automations section wiring from the management editor (imports, fields, widget creation, layout, visibility, focus)

  • Removed the focusAutomation deep-link case from the contribution

  • Removed all .automations-list-widget CSS rules

  • Removed Automations from the customizations toolbar, tree view, and overview tiles in the sidebar

  • Retargeted the automation-configured chat result button to navigate to the sessions custom view instead of the removed editor section

  • Cleaned up dead parameters and interface fields surfaced during review

  • Deep links from the chat result button (chatAutomationConfiguredResultSubPart) now navigates to the sessions automations custom view generically, as the new view does not yet have deep link support cc @ulugbekna

The Automations UX has moved to a dedicated custom view in the sessions
app sidebar. Remove the old widget, accessibility help, and all wiring
from the AI Customization Management Editor.

- Delete automationsListWidget.ts and automationsAccessibilityHelp.ts
- Delete corresponding test files
- Remove widget creation, layout, visibility, and focus handling from
  the editor
- Remove deep-link focusAutomation case from contribution
- Remove stale AccessibilityHelp registration from sessions contribution
- Keep Automations enum value (sessions app still depends on it)
All .automations-list-widget rules and the .automations-content-container
shared selector entry are now unused after the widget removal. The sessions
app uses its own independent CSS (automationsCards.css).
The button in chat results previously opened the AI Customizations editor
at the Automations section. Now that the section is removed, navigate to
the sessions automations custom view instead.
When clicking the Automations link in the AI customization tree,
navigate to the sessions custom view instead of the removed
editor section.
When clicking the Automations tile in the overview panel,
navigate to the sessions custom view instead of opening the
management editor.
The Automations entry in the AI Customizations tree view is no longer
needed. Users access automations through the dedicated custom view
in the sessions sidebar instead.
Remove the Automations section tile, its reactive count update,
and the config listener that toggled its visibility.
Remove the Automations entry from the sessions sidebar
customizations toolbar, its count logic, and dead imports.
Copilot AI review requested due to automatic review settings August 3, 2026 03:02

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the obsolete Automations UI from AI Customizations now that automation management lives in the Sessions custom view.

Changes:

  • Deletes the old widget, accessibility provider, styles, fixtures, and tests.
  • Removes Automations entries and editor wiring.
  • Retargets chat results to the Sessions Automations view.
Show a summary per file
File Description
aiCustomizationManagementEditor.fixture.ts Removes Automations fixture.
automationsListWidget.test.ts Deletes obsolete widget tests.
automationsAccessibilityHelp.test.ts Deletes obsolete help tests.
aiCustomizationManagementEditor.test.ts Removes visibility test and fields.
chatAutomationConfiguredResultSubPart.ts Redirects result button to Sessions view.
aiCustomizationManagement.css Removes widget styles.
automationsListWidget.ts Deletes old management widget.
automationsAccessibilityHelp.ts Deletes old accessibility provider.
aiCustomizationManagementEditor.ts Removes Automations section integration.
aiCustomizationManagement.contribution.ts Removes automation deep-link handling.
customizationsToolbar.contribution.ts Removes toolbar entry and count.
automations.contribution.ts Removes old help registration.
aiCustomizationTreeViewViews.ts Removes Automations tree link.
aiCustomizationOverviewView.ts Removes Automations overview tile.

Review details

  • Files reviewed: 14/14 changed files
  • Comments generated: 3
  • Review effort level: Balanced

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Screenshot Changes

Base: d5dd3ab6 Current: 4984a1d5

Changed (6)

sessions/aiCustomizationShortcutsWidget/Expanded/Dark
Before After
before after
sessions/aiCustomizationShortcutsWidget/Expanded/Light
Before After
before after
sessions/aiCustomizationShortcutsWidget/WithMcpServers/Dark
Before After
before after
sessions/aiCustomizationShortcutsWidget/WithMcpServers/Light
Before After
before after
sessions/aiCustomizationShortcutsWidget/WithCounts/Dark
Before After
before after
sessions/aiCustomizationShortcutsWidget/WithCounts/Light
Before After
before after

1 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details.

Removed (2)

chat/aiCustomizations/aiCustomizationManagementEditor/AutomationsTab/Dark

baseline

chat/aiCustomizations/aiCustomizationManagementEditor/AutomationsTab/Light

baseline

benvillalobos and others added 6 commits August 2, 2026 20:17
…NS.md

The paragraphs describing the management editor widget's dynamic row
heights, visibility propagation, and empty-state CTA are no longer
accurate now that the widget has been removed.
Remove the automationsEnabled option, its config wiring, and the
CHAT_AUTOMATIONS_ENABLED_SETTING import from the fixture. No remaining
fixture passes this option. Service stubs kept for DI stability.
The fixture was removed, so CI expects these entries gone.
@benvillalobos
benvillalobos marked this pull request as ready for review August 3, 2026 04:06
@benvillalobos
benvillalobos enabled auto-merge (squash) August 3, 2026 04:08
@benvillalobos
benvillalobos merged commit 4bbdaa9 into main Aug 3, 2026
29 checks passed
@benvillalobos
benvillalobos deleted the bv/remove-automations-from-customizations-editor branch August 3, 2026 04:37
@vs-code-engineering vs-code-engineering Bot added this to the 1.132.0 milestone Aug 3, 2026
benvillalobos added a commit that referenced this pull request Aug 4, 2026
* Hide the 'New Automation' button when there are no automations

* Fix caps

* Fix context key setting for btn

* Always show custom view header divider

Previously the bottom border on the custom view header band was transparent
by default and only became visible when the user scrolled down (via the
.scrolled class toggled in customViewNode.ts). This meant the divider
between the header and content was invisible at the top scroll position.

Change the border color to always be visible so the header is consistently
separated from the content regardless of scroll position.

* Move automation dialog CSS to dedicated file and fix button padding

The automation dialog CSS was still living in aiCustomizationManagement.css
after the automations list widget was removed in #328654. Move it to a
dedicated automationDialog.css file next to the dialog service and add the
import there.

Also fix padding issues where Create/Cancel buttons and the close button
were too close to the dialog border (padding: 0 was inherited from the
base dialog override):
- dialog-toolbar-row (close button): 4px/6px → 8px/10px from top/right
- dialog-buttons-row: add 8px top, 10px side, 10px bottom padding

* Fix pointer cursor on automation dialog form labels

Schedule, Time, Day of week, and Prompt labels were rendered as <label>
elements without 'for' attributes. Chromium applies cursor: pointer to
<label> elements regardless of author CSS, making them look like links.

Change them to <span> elements since they are purely visual section
headers with no programmatic association to their controls.

* Fix extra spacing around automation dialog prompt input

chat.css sets padding: 4px 0 on .interactive-input-part, designed for
the full chat panel. In the compact dialog this adds visible dead space
above the rounded input container (below the Prompt label) and below
the secondary toolbar. Zero out both ends.

Also reduce the 6px bottom padding inside .chat-input-container (between
the picker chips and the container border) to 2px.

* Truncate long automation card titles with ellipsis

word-break: break-word on the card name container caused the Disabled
badge to word-wrap when titles were long. Replace with ellipsis
truncation on the title text so the badge always stays on one line.

* Use editorWidget.border token for automation card outlines

widget.border is transparent in many themes, making cards invisible.
Switch to editorWidget.border which has concrete defaults across light
and dark themes, and add a contrastBorder override for HC themes.

* Fix ellipsis truncation on automation card titles and add context key test

The title span needs flex: 1 1 0; min-width: 0 to actually shrink as a
flex item — without it the min-width: auto default prevents ellipsis from
engaging on long unbroken strings.

Also add test coverage for the AutomationsHasItemsContext global context
key fix: verifies the key transitions false → true → false as the
automations observable changes through empty/non-empty/empty states.
Export AutomationsCustomViewContribution to enable direct instantiation
in the test.

* Always show header divider for automations view

Stamp data-view-id on the custom view node element so individual views
can override the scroll-driven divider behavior via CSS. Use this to
always show the header bottom border in the automations view, while
keeping the scroll-driven behavior intact for any other custom views.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants