Skip to content

Consolidate the two "Select Microphone" commands into one - #328835

Open
meganrogge with Copilot wants to merge 3 commits into
mainfrom
copilot/closes-microsoft-vscode-328790
Open

Consolidate the two "Select Microphone" commands into one#328835
meganrogge with Copilot wants to merge 3 commits into
mainfrom
copilot/closes-microsoft-vscode-328790

Conversation

Copilot AI commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

The command palette exposed two commands that both pick a microphone and persist to the same AgentsVoiceStorageKeys.MicrophoneDevice storage key: Chat: Dictate: Select Microphone and Voice: Select Microphone. The Voice Mode variant was fully redundant — the dictation command is already the one wired into both the dictation and Voice Mode mic-button context menus.

Description

  • Removed agentsVoice.selectMicrophone (Voice: Select Microphone) and its now-unused IQuickInputService import in agentsVoice.contribution.ts.
  • Generalized the surviving workbench.action.chat.selectSpeechToTextMicrophone:
    • Retitled "Dictate: Select Microphone""Select Microphone" (still under the Chat category → Chat: Select Microphone).

    • Broadened the precondition so it stays discoverable when either feature is on:

      precondition: ContextKeyExpr.or(
          ChatSpeechToTextConfigured,
          ContextKeyExpr.equals('config.agents.voice.enabled', true)
      ),

The kept command uses the canonical buildMicrophoneOptions normalization (including the "System default" entry that clears the stored device), so no behavior is lost for Voice-Mode-only users.

Copilot AI requested review from Copilot and removed request for Copilot August 3, 2026 20:39
Copilot AI linked an issue Aug 3, 2026 that may be closed by this pull request
Co-authored-by: meganrogge <29464607+meganrogge@users.noreply.github.com>
Copilot AI requested review from Copilot and removed request for Copilot August 3, 2026 20:45
Copilot AI changed the title [WIP] Refactor microphone command settings implementation Consolidate the two "Select Microphone" commands into one Aug 3, 2026
Copilot AI requested a review from meganrogge August 3, 2026 20:45
@meganrogge
meganrogge marked this pull request as ready for review August 4, 2026 19:26
Copilot AI balanced review requested due to automatic review settings August 4, 2026 19:26
@meganrogge
meganrogge enabled auto-merge (squash) August 4, 2026 19:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Consolidates microphone selection into one shared Chat command.

Changes:

  • Renames and broadens the surviving microphone command.
  • Removes the redundant Voice Mode command.
Show a summary per file
File Description
chatSpeechToTextActions.ts Generalizes the shared command.
agentsVoice.contribution.ts Removes the duplicate Voice command.

Review details

  • Files reviewed: 2/2 changed files
  • Comments generated: 2
  • Review effort level: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do we need 2 commands to set the microphone?

4 participants