Skip to content

Add component fixture rendering controls - #328941

Merged
hediet merged 1 commit into
mainfrom
hediet/component-explorer-fixture-controls
Aug 4, 2026
Merged

Add component fixture rendering controls#328941
hediet merged 1 commit into
mainfrom
hediet/component-explorer-fixture-controls

Conversation

@hediet

@hediet hediet commented Aug 4, 2026

Copy link
Copy Markdown
Member

Adds explicit Component Explorer controls for fixture rendering without changing screenshot defaults.

  • Declares toolbar toggles for normal/reversed stylesheet order and CSS animations
  • Keeps animations disabled by default
  • Splits ranged stylesheet reversal into reverseStylesheetsRange so the Explorer does not need to render a union input
  • Updates the scheduled CSS order scanner's bisection probes to use the range input
  • Supports shared live controls when multiple theme variants are mounted

Validation:

  • Component Explorer Playwright tests: 13 passed
  • Ranged render through Component Explorer CLI: passed
  • Pre-commit hygiene: passed
  • npm run typecheck-client: blocked by pre-existing AuthenticationResponseDetails.firstAuthAttempt error in src/vs/platform/native/electron-main/auth.ts

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: d04b3d01-1bb4-4c9e-af2a-86b97a8934c5
Copilot AI balanced review requested due to automatic review settings August 4, 2026 10:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds live Component Explorer rendering controls while preserving screenshot defaults.

Changes:

  • Adds stylesheet-order and animation toolbar controls.
  • Supports concurrent themed fixtures with shared stylesheet overrides.
  • Moves ranged reversal to reverseStylesheetsRange and updates scanner probes.
Show a summary per file
File Description
test/componentFixtures/cssOrderShared.mts Uses the new ranged-reversal input.
src/vs/workbench/test/browser/componentFixtures/fixtureUtilsCss.ts Supports stacked stylesheet overrides.
src/vs/workbench/test/browser/componentFixtures/fixtureUtils.ts Defines controls and applies live input updates.

Review details

  • Files reviewed: 3/3 changed files
  • Comments generated: 0
  • Review effort level: Balanced

@hediet
hediet merged commit d510219 into main Aug 4, 2026
30 checks passed
@hediet
hediet deleted the hediet/component-explorer-fixture-controls branch August 4, 2026 14:46
@vs-code-engineering vs-code-engineering Bot added this to the 1.133.0 milestone Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants