fix(editor): use embedded language for definition previews - #329161
Open
liangmiQwQ wants to merge 4 commits into
Open
fix(editor): use embedded language for definition previews#329161liangmiQwQ wants to merge 4 commits into
liangmiQwQ wants to merge 4 commits into
Conversation
Author
|
@microsoft-github-policy-service agree |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates definition previews to use the target model’s embedded language identifier for syntax highlighting.
Changes:
- Resolves the language at the definition position.
- Adds a regression test for embedded-language previews.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
goToDefinitionAtPosition.ts |
Uses tokenization to determine the preview language. |
goToDefinitionAtPosition.test.ts |
Tests an embedded-language definition preview. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #329160
Instead of guessing the file type from the URL, it now use the exact language id from the code's position. So these problems will no longer exist.
🤖 This PR is submitted with help with Codex.