Fix pending message sync loops for element attachments - #329210
Merged
Conversation
kycutler
requested review from
connor4312 and
roblourens
and
a balanced review from Copilot
August 5, 2026 17:06
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents pending-message synchronization loops when element attachments are projected between chat models and Agent Host state.
Changes:
- Suppresses outbound synchronization during remote projections.
- Preserves stable element attachment correlation IDs.
- Adds regression coverage for idempotent local and remote synchronization.
Show a summary per file
| File | Description |
|---|---|
agentHostSessionHandler.ts |
Stabilizes attachment metadata and guards remote projection. |
agentHostChatContribution.test.ts |
Tests loop prevention and correlation preservation. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
connor4312
previously approved these changes
Aug 5, 2026
…ler/syncloops # Conflicts: # src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/agentHostSessionHandler.ts
kycutler
enabled auto-merge (squash)
August 5, 2026 18:00
connor4312
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref https://github.com/microsoft/vscode-internalbacklog/issues/8730