Skip to content

sessions: keep Changes and Files in aux-only view - #329448

Merged
Sandeep Somavarapu (sandy081) merged 3 commits into
mainfrom
sandy081/agents/single-sidepane-aux-bar-changes
Aug 7, 2026
Merged

sessions: keep Changes and Files in aux-only view#329448
Sandeep Somavarapu (sandy081) merged 3 commits into
mainfrom
sandy081/agents/single-sidepane-aux-bar-changes

Conversation

@sandy081

Copy link
Copy Markdown
Member

Summary

  • treat the single-pane Aux-only composition as an invariant that always provides the managed Changes and Files inputs
  • reconcile on every part visibility transition so Editor+Aux to Aux-only restores a missing Files input
  • preserve user-close behavior while the Editor area is visible
  • update the single-pane layout specification and regression coverage

Validation

  • npm run compile
  • npm run hygiene
  • npm run typecheck-client
  • npm run valid-layers-check
  • ./scripts/test.sh --run src/vs/sessions/contrib/layout/test/browser/desktopSessionLayoutController.test.ts --grep "managed tabs" (30 passing)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings August 6, 2026 15:59
@sandy081 Sandeep Somavarapu (sandy081) added this to the 1.133.0 milestone Aug 6, 2026
auto-merge was automatically disabled August 6, 2026 16:13

Pull request was closed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Note

This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.

auto-merge was automatically disabled August 6, 2026 17:14

Pull request was closed

@dmitrivMS
Dmitriy Vasyura (dmitrivMS) requested a balanced review from Copilot August 6, 2026 20:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Note

This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.

@vs-code-engineering

Copy link
Copy Markdown
Contributor

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

Benjamin Christopher Simmonds (@benibenj)

Matched files:

  • src/vs/sessions/contrib/layout/browser/singlePane/singlePaneManagedTabsStrategy.ts
  • src/vs/sessions/contrib/layout/test/browser/desktopSessionLayoutController.test.ts

@dmitrivMS
Dmitriy Vasyura (dmitrivMS) requested a balanced review from Copilot August 6, 2026 22:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Note

This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.

@sandy081
Sandeep Somavarapu (sandy081) merged commit e5770ec into main Aug 7, 2026
29 checks passed
@sandy081
Sandeep Somavarapu (sandy081) deleted the sandy081/agents/single-sidepane-aux-bar-changes branch August 7, 2026 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants