Sticky header on by default and rename - #329691
Merged
Osvaldo Ortega (osortega) merged 5 commits intoAug 8, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates chat timeline settings to stable defaults while removing obsolete Insiders-era names and migration logic.
Changes:
- Renames timeline display and sticky-scroll settings.
- Enables sticky scroll and dock display by default.
- Updates consumers, documentation, and tests to use the new settings.
Show a summary per file
| File | Description |
|---|---|
promptTimelineVisibility.test.ts |
Updates visibility tests for the renamed setting. |
promptTimeline.ts |
Defines the new configuration keys. |
promptTimelineWidgetContrib.ts |
Consumes and observes the new settings. |
promptTimelineDockRail.ts |
Updates setting documentation. |
promptTimeline.contribution.ts |
Registers new defaults and removes migration logic. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Balanced
`dock` was not part of VS Code's vocabulary — it usually means panel docking — and it collided with the ruler rail's own use of "dock" for its evenly spaced pill layout. VS Code already pairs `gutter` with `overviewRuler` for exactly this split (see `scm.diffDecorations` and the terminal's shell integration decorations), and this rail's own docs already described it as living in the transcript's left gutter. Rename the `sessions.chatTimeline.display` enum value, the rail class and its files, and the CSS classes and custom properties to match. The ruler rail's remaining "dock" wording describes its macOS-dock-style fisheye, not a rail style, so it stays. Also drop the `experimental` tag from both timeline settings now that they are on by default: the badge told users the feature may be unstable and subject to removal, which no longer holds. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Review details
Suppressed comments (1)
src/vs/workbench/contrib/chat/browser/promptTimeline/promptTimeline.contribution.ts:38
- The PR description says
sessions.chatTimeline.displaydefaults todock, but the schema no longer acceptsdockand defaults togutter. Please either retain the documenteddockvalue throughout or update the PR description/requirements to explicitly usegutterso the rollout behavior is unambiguous.
default: 'gutter',
- Files reviewed: 9/9 changed files
- Comments generated: 0 new
- Review effort level: Balanced
Sticky scroll is ready to ship on by default everywhere, but the gutter rail is still being tried out, so gate its default back on quality and restore the `experimental` tag it warrants. The setting stays available on stable for anyone who wants to opt in. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Osvaldo Ortega (osortega)
marked this pull request as ready for review
August 7, 2026 23:52
Osvaldo Ortega (osortega)
enabled auto-merge (squash)
August 7, 2026 23:52
Osvaldo Ortega (osortega)
changed the title
Osvaldo Ortega (osortega)
changed the title
Dmitriy Vasyura (dmitrivMS)
previously approved these changes
Aug 7, 2026
2 tasks
The header's label roll asked the OS directly via a `prefers-reduced-motion` media query, so `workbench.reduceMotion: "on"` did not stop it while the OS still allowed motion. The band's own CSS already follows the workbench-managed `.monaco-reduce-motion` class for exactly this reason, so the two disagreed. Use `IAccessibilityService.isMotionReduced()`, which resolves the effective setting (`on`, or `auto` plus the OS preference), so the animation and the stylesheet agree. This matters more now that the header is on by default for everyone rather than just insiders. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dmitriy Vasyura (dmitrivMS)
approved these changes
Aug 8, 2026
Osvaldo Ortega (osortega)
deleted the
osortega/agents/remove-sticky-header-enable-default
branch
August 8, 2026 00:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes the unnecessary migration code and updates the configuration settings for the chat timeline feature. The changes include:
chat.stickyScroll.enabledis now enabled by default for all users, with the default value set totrue.sessions.chatTimeline.displayis also enabled by default, with its default value set todock.promptTimelinesettings, as they were only applicable to Insiders.All changes have been validated with ESLint and diff checks, ensuring no stale references remain.