Skip to content

Handle incomplete Extension Gallery latest responses - #330527

Open
Dmitriy Vasyura (dmitrivMS) wants to merge 1 commit into
mainfrom
dmitriv/fix-gallery-missing-files
Open

Handle incomplete Extension Gallery latest responses#330527
Dmitriy Vasyura (dmitrivMS) wants to merge 1 commit into
mainfrom
dmitriv/fix-gallery-missing-files

Conversation

@dmitrivMS

Copy link
Copy Markdown
Collaborator

Summary

  • treat latest-version responses without asset-file metadata as incomplete
  • use the existing Extension Gallery query fallback without logging a TypeError
  • make raw asset lookup tolerate omitted files
  • cover the managed-feed response shape with a focused service test

Testing

  • npm run transpile-client
  • scripts\test.bat --run src\vs\platform\extensionManagement\test\common\extensionGalleryService.test.ts (31 passing)

Fixes #330526

Fixes #330526

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings August 12, 2026 19:43
@dmitrivMS Dmitriy Vasyura (dmitrivMS) added bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions labels Aug 12, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Handles incomplete Extension Gallery responses by falling back cleanly to the query API.

Changes:

  • Makes raw extension file metadata optional and asset lookup null-safe.
  • Detects missing metadata before processing latest versions.
  • Adds focused fallback and error-logging coverage.
Show a summary per file
File Description
extensionGalleryService.ts Handles omitted version files and triggers query fallback.
extensionGalleryService.test.ts Verifies fallback occurs without logging errors.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Balanced

Copilot AI commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

One or more custom setup steps configured for this repository failed during this Copilot code review run:

Download Electron and Playwright

Setup steps run before each review. If the review above is missing context, or no review was posted at all, the failing step above may be the cause. See the workflow run for failure details, fix your setup steps configuration, and re-request a review.

Note

You can configure setup steps for Copilot code review separately from Copilot cloud agent with a copilot-code-review.yml file. Read the docs for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extension Gallery logs TypeErrors when latest-version metadata omits files

3 participants