Skip to content

Allow NOTICE fallback to complete in product builds - #330564

Merged
Paul (pwang347) merged 1 commit into
microsoft:mainfrom
pwang347:fix/quality-notice-timeouts
Aug 13, 2026
Merged

Allow NOTICE fallback to complete in product builds#330564
Paul (pwang347) merged 1 commit into
microsoft:mainfrom
pwang347:fix/quality-notice-timeouts

Conversation

@pwang347

Copy link
Copy Markdown
Member

Summary

  • increase the OSPO NOTICE generation timeout from 10 to 15 minutes so its configured retries have more time to run
  • increase the enclosing Quality job timeout from 20 to 30 minutes so the cached NOTICE fallback and remaining quality steps can complete
  • preserve continueOnError behavior, allowing Publish to accept the resulting succeededWithIssues stage

This addresses the failure mode observed in build 464142, where NOTICE generation timed out, the fallback worked, but the Quality job reached its overall timeout and was reported as failed.

Validation

  • git diff --check
  • pre-commit hygiene check
  • verified the publisher accepts both succeeded and succeededWithIssues Quality stage results

Increase the NOTICE task and Quality job timeouts so retries can finish and the cached fallback can preserve a succeeded-with-issues stage result.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 0d98a62b-9576-44fa-a3cb-d7de5f26f917
Copilot AI balanced review requested due to automatic review settings August 12, 2026 23:03
@vs-code-engineering

Copy link
Copy Markdown
Contributor

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

Ladislau Szomoru (@lszomoru)

Matched files:

  • build/azure-pipelines/product-quality-checks.yml

@pwang347
Paul (pwang347) enabled auto-merge (squash) August 12, 2026 23:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Extends pipeline timeouts so NOTICE retries and cached fallback can complete during product builds.

Changes:

  • Raises the Quality job timeout from 20 to 30 minutes.
  • Raises NOTICE generation timeout from 10 to 15 minutes.
Show a summary per file
File Description
build/azure-pipelines/product-quality-checks.yml Adjusts Quality job and NOTICE task timeout budgets.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Balanced

Comment thread build/azure-pipelines/product-quality-checks.yml
@pwang347
Paul (pwang347) merged commit df4e4d9 into microsoft:main Aug 13, 2026
44 of 45 checks passed
@vs-code-engineering vs-code-engineering Bot added this to the 1.134.0 milestone Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants