Skip to content

sessions: Share modern editor tab styles with chat tabs - #330858

Merged
Sandeep Somavarapu (sandy081) merged 1 commit into
mainfrom
sandy081/agents/modern-ui-tabs-investigation
Aug 14, 2026
Merged

sessions: Share modern editor tab styles with chat tabs#330858
Sandeep Somavarapu (sandy081) merged 1 commit into
mainfrom
sandy081/agents/modern-ui-tabs-investigation

Conversation

@sandy081

Copy link
Copy Markdown
Member

Summary

  • expose reusable Modern UI editor-tab hooks from the canonical tab stylesheet
  • apply the shared geometry, typography, colors, hover, focus, and high-contrast states to Agents chat tabs
  • remove duplicated Sessions-owned tab presentation while retaining chat-specific layout and adornments
  • document and test the shared styling contract

Why

Agents chat tabs had copied editor-tab styling and drifted from the Changes editor tab. Sharing the canonical declarations keeps both surfaces visually aligned as Modern UI evolves.

Validation

  • npm run compile
  • npm run hygiene
  • ./scripts/test.sh --grep "Sessions - ChatCompositeBar"
  • targeted stylelint for the changed CSS
  • live computed-style and screenshot comparison against the Changes tab

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings August 14, 2026 13:37
@sandy081 Sandeep Somavarapu (sandy081) added this to the 1.134.0 milestone Aug 14, 2026
@vs-code-engineering

Copy link
Copy Markdown
Contributor

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

Benjamin Christopher Simmonds (@benibenj)

Matched files:

  • src/vs/sessions/browser/parts/chatCompositeBar.ts
  • src/vs/sessions/browser/parts/media/chatCompositeBar.css

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Shares canonical Modern UI editor-tab styling with Agents chat tabs.

Changes:

  • Adds reusable editor-tab CSS hooks.
  • Adopts hooks in chat tabs and removes duplicated styling.
  • Updates documentation and structural tests.
Show a summary per file
File Description
tabs.css Adds shared tab presentation hooks.
chatCompositeBar.css Retains chat-specific layout and adornments.
chatCompositeBar.ts Applies shared hook classes.
chatCompositeBar.test.ts Verifies shared presentation structure.
LAYOUT.md Documents shared styling ownership.

Review details

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 5/5 changed files
  • Comments generated: 4
  • Review effort level: Balanced

Comment thread src/vs/workbench/contrib/styleOverrides/browser/media/tabs.css
Comment thread src/vs/sessions/browser/parts/media/chatCompositeBar.css
Comment thread src/vs/sessions/LAYOUT.md
Comment thread src/vs/workbench/contrib/styleOverrides/browser/media/tabs.css
@github-actions

Copy link
Copy Markdown
Contributor

Screenshot Changes

Base: be7d2fa5 Current: 0f2cfc90

Changed (10)

sessions/chatCompositeBar/TwoChats/Dark
Before After
before after
sessions/chatCompositeBar/TwoChats/Light
Before After
before after
sessions/chatCompositeBar/MixedStatuses/Dark
Before After
before after
sessions/chatCompositeBar/MixedStatuses/Light
Before After
before after
sessions/chatCompositeBar/LongTitles/Dark
Before After
before after
sessions/chatCompositeBar/LongTitles/Light
Before After
before after
sessions/chatCompositeBar/Renaming/Dark
Before After
before after
sessions/chatCompositeBar/Renaming/Light
Before After
before after
sessions/chatCompositeBar/WithDraftChat/Dark
Before After
before after
sessions/chatCompositeBar/WithDraftChat/Light
Before After
before after

@sandy081
Sandeep Somavarapu (sandy081) merged commit c35c8e9 into main Aug 14, 2026
28 checks passed
@sandy081
Sandeep Somavarapu (sandy081) deleted the sandy081/agents/modern-ui-tabs-investigation branch August 14, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants