fix: memory leak in explorer viewer - #332332
Merged
Dmitriy Vasyura (dmitrivMS) merged 8 commits intoAug 24, 2026
Merged
Conversation
…ry-leak-explorer-viewer
Copilot started reviewing on behalf of
Simon Siefke (SimonSiefke)
August 24, 2026 14:15
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an Explorer viewer memory leak by releasing the drag-and-drop configuration listener when its tree is disposed.
Changes:
- Disposes
FileDragAndDrop’sDisposableStoreduring teardown.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Logan Ramos (lramos15)
approved these changes
Aug 24, 2026
Dmitriy Vasyura (dmitrivMS)
approved these changes
Aug 24, 2026
Collaborator
|
Simon Siefke (@SimonSiefke) Thank you! |
Dmitriy Vasyura (dmitrivMS)
enabled auto-merge (squash)
August 24, 2026 16:43
Ladislau Szomoru (lszomoru)
approved these changes
Aug 24, 2026
Simon Siefke (SimonSiefke)
deleted the
fix/memory-leak-explorer-viewer
branch
September 1, 2026 14:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
FileDragAndDropregisters anexplorer.enableDragAndDropconfiguration listener in itsDisposableStore. When Explorer is moved to the panel, the old viewer is disposed but that store stays live, soupdateDropEnablementand the retired Explorer viewer tree remain reachable.Change
Dispose the
FileDragAndDropstore together with its other drag-and-drop resources.Before
When moving Explorer to the panel 17 times,
updateDropEnablementgrows by 17 and retains the associated Explorer viewer callbacks:After
No more explorer viewer leak is detected.
Test Video
test-video.webm