Route terminal output sources through active parts

[Dmitriy Vasyura (dmitrivMS)]

Summary

• remove the shared onDidRegisterOutputSource event from ITerminalChatService
• notify active terminal progress parts directly when an output source is registered
• let each part filter by terminal tool session ID before attaching the source
• preserve the initial lookup path when the source is registered before the row renders
• add duplicate-row regression coverage

Root cause

Every output-only terminal row subscribed to one service-wide onDidRegisterOutputSource emitter. Tool-heavy Agent Host chats accumulated one listener per rendered row until the leak detector crossed its threshold.

Recent Insiders logs identify this path directly:

potential listener LEAK detected, popular
    at ... onDidRegisterOutputSource
    at ... createToolInvocationSubPart

The output-source event had no consumers other than terminal progress rows. TerminalChatService.registerOutputSource() now updates the source map and directly notifies its existing active-progress-part registry. The event and its emitter are removed from the service contract.

Validation

• npm run transpile-client
• focused duplicate-row regression test: 1 passed
• full TerminalChatService suite: 7 passed
• chat terminal rendering suite: 15 passed
• 50 active parts are registered, including two rows sharing the target session ID; both matching rows are notified
• editor diagnostics: no errors
• git diff --check

Related issues

Related to #311225
Related to #294050

These reports contain multiple independent renderer and extension-host retention paths, so the references are intentionally non-closing.

[Copilot]

Pull request overview

Routes terminal output-source registration through active progress parts, avoiding service-wide listener accumulation.

Changes:

• Removes the shared output-source event.
• Directly notifies active rows, with per-row session filtering.
• Adds duplicate-row regression coverage.

Show a summary per file

File	Description
terminalChatService.test.ts	Tests notification of duplicate matching rows.
terminalChatService.ts	Routes registrations through active progress parts.
terminal.ts	Updates terminal chat interfaces.
chatTerminalToolProgressPart.ts	Filters and attaches matching output sources.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

• Files reviewed: 4/4 changed files
• Comments generated: 0
• Review effort level: Balanced

[Saswwo (saroasid-web)]

الجامد بزيادة

[Saswwo (saroasid-web)]

https://docs.github.com/en/copilot/how-to/use-code-review

[Dmitriy Vasyura (dmitrivMS)]

Copilot resolve the merge conflicts in this pull request

[Copilot]

Copilot resolve the merge conflicts in this pull request

Resolved the merge conflicts in 8d07e46. The focused terminal chat service browser tests pass.