Skip to content

chat: resolve MCP App resources through agent host - #332653

Merged
Connor Peet (connor4312) merged 3 commits into
microsoft:mainfrom
connor4312:connor4312/fix-mcp-app-uri-transformation
Aug 25, 2026
Merged

chat: resolve MCP App resources through agent host#332653
Connor Peet (connor4312) merged 3 commits into
microsoft:mainfrom
connor4312:connor4312/fix-mcp-app-uri-transformation

Conversation

@connor4312

Copy link
Copy Markdown
Member

chat: resolve MCP App resources through agent host

Routes resource links from agent-host MCP Apps through the connection-specific URI mapper.

  • Adds the connection authority to agent-host MCP App render data.
  • Converts App resource URIs with toAgentHostUri before the workbench uses them.
  • Updates adapter tests for the new render data.

(Commit message generated by Copilot)

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

Routes resource links from agent-host MCP Apps through the connection-specific URI mapper.

- Adds the connection authority to agent-host MCP App render data.
- Converts App resource URIs with toAgentHostUri before the workbench uses them.
- Updates adapter tests for the new render data.

(Commit message generated by Copilot)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings August 25, 2026 22:34
@connor4312
Connor Peet (connor4312) enabled auto-merge (squash) August 25, 2026 22:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Routes Agent Host MCP App resource links through connection-aware URI handling.

Changes:

  • Adds connection authority to MCP App render data.
  • Wraps Agent Host resource links for workbench resolution.
  • Updates adapter expectations.
Show a summary per file
File Description
stateToProgressAdapter.test.ts Updates MCP App expectations.
chatService.ts Adds connection authority metadata.
chatMcpAppModel.ts Maps Agent Host resource URIs.
stateToProgressAdapter.ts Propagates connection authority.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 4/4 changed files
  • Comments generated: 2
  • Review effort level: Balanced

Comment thread src/vs/workbench/contrib/chat/common/chatService/chatService.ts
Includes the connection authority when comparing agent-host MCP App render data. This recreates the
model when resource routing moves to another agent-host connection.

(Commit message generated by Copilot)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@connor4312
Connor Peet (connor4312) merged commit 71f7505 into microsoft:main Aug 25, 2026
27 checks passed
@vs-code-engineering vs-code-engineering Bot added this to the 1.136.0 milestone Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants