sessions: add dynamic codicon chat backgrounds - #332660
Merged
Merged
Conversation
Add a theme-aware in-memory Codicons preset alongside image backgrounds. Reconcile Set/Clear/Layout commands across background types, add live layout previews with commit-on-close behavior, and retain a five-image machine-local MRU for quick reuse. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Roll back transient layout state to the configured value when the settings write fails, so an unsaved preview cannot remain active. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds configurable, theme-aware Codicon and recent-image backgrounds to Sessions chat.
Changes:
- Adds responsive decorative Codicon rendering.
- Adds background presets, recent images, and layout previews.
- Updates commands, accessibility help, styling, and tests.
Show a summary per file
| File | Description |
|---|---|
contextkeys.ts |
Adds configured-background context. |
chatBackgroundService.ts |
Manages presets, layouts, and recents. |
chatBackgroundService.test.ts |
Tests new service behavior. |
chatBackgroundRenderer.ts |
Renders image and Codicon backgrounds. |
chatView.ts |
Integrates the renderer. |
chatView.css |
Styles background layers and content. |
chat.contribution.ts |
Updates commands and settings. |
sessionsChatAccessibilityHelp.ts |
Documents accessible background controls. |
chatView.test.ts |
Tests renderer behavior and styling. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 9/9 changed files
- Comments generated: 1
- Review effort level: Balanced
Restore an in-memory layout preview without writing configuration when the picker is cancelled or rejects. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use one union-typed service method for both image and built-in background selections while preserving image-only recent history behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
TylerLeonhardt
marked this pull request as ready for review
August 26, 2026 02:26
Justin Chen (justschen)
approved these changes
Aug 26, 2026
Justin Chen (justschen)
left a comment
Collaborator
There was a problem hiding this comment.
developer joy
TylerLeonhardt
enabled auto-merge (squash)
August 26, 2026 03:26
Christof Marti (chrmarti)
approved these changes
Aug 26, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
npm run compilenpm run typecheck-client.\scripts\test.bat src\vs\sessions\contrib\chat\test\browser\chatView.test.ts src\vs\sessions\services\chatBackground\test\browser\chatBackgroundService.test.ts(25 passing)node --experimental-strip-types build\hygiene.ts <all 9 changed files>git diff --check origin/main...HEADReviewer note
The full
npm run hygienewrapper currently fails in this Windows checkout before source checks because it resolves paths with a duplicatedC:\C:\...prefix. Runningbuild\hygiene.tsdirectly against every changed file passes.