agentHost: canonicalize missing paths through all ancestors - #332668
Merged
Connor Peet (connor4312) merged 1 commit intoAug 26, 2026
Conversation
The resource service now walks parent directories until it finds an existing path. It then applies realpath to that ancestor and appends the missing suffix before the grant check. - Walks ancestors in _canonicalize instead of only the immediate parent - Adds a unit test for nested missing paths through a directory symlink - Keeps coverage for new files that stay inside the granted tree (Commit message generated by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates resource permission checks to canonicalize nested missing paths through existing ancestors.
Changes:
- Walks ancestors until
realpathsucceeds. - Adds symlink and granted-tree regression coverage.
Show a summary per file
| File | Description |
|---|---|
agentHostResourceService.ts |
Canonicalizes missing path suffixes. |
agentHostResourceService.test.ts |
Tests nested missing paths through symlinks. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
|
تم |
TylerLeonhardt
approved these changes
Aug 26, 2026
Connor Peet (connor4312)
deleted the
connor4312/agent-host-canonicalize-ancestors
branch
August 26, 2026 02:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
agentHost: canonicalize missing paths through all ancestors
The resource service now walks parent directories until it finds an
existing path. It then applies realpath to that ancestor and appends
the missing suffix before the grant check.
_canonicalizeinstead of only the immediate parent(Commit message generated by Copilot)