agentHost: temporarily disable retryable errors - #332839
Merged
Merged
Conversation
Stop marking Copilot errors as resumable while keeping the retry protocol and implementation available for later re-enablement. Update focused coverage and park retry-only E2E scenarios.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Aaron Munger (amunger)
previously approved these changes
Aug 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Temporarily disables in-place retries for Copilot errors while preserving the underlying retry implementation.
Changes:
- Removes
resumablemarkers from live and restored Copilot errors. - Makes failed continuations non-resumable.
- Updates tests and documents skipped retry scenarios.
Show a summary per file
| File | Description |
|---|---|
node/copilot/mapSessionEvents.ts |
Restores errors without resumability. |
node/copilot/copilotAgentSession.ts |
Emits non-resumable Copilot errors. |
node/agentSideEffects.ts |
Makes continuation failures non-resumable. |
test/node/mapSessionEvents.test.ts |
Updates restoration expectations. |
test/node/copilotAgentSession.test.ts |
Updates live-error expectations. |
test/node/agentService.test.ts |
Tests non-resumable continuation failure. |
test/node/e2e/providers/copilotAgentHostE2E.integrationTest.ts |
Updates restart assertions and skips retry scenarios. |
test/node/e2e/KNOWN_ISSUES.md |
Documents the temporary disablement. |
Review details
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 8/8 changed files
- Comments generated: 1
- Review effort level: Balanced
Verify that a resume action for a non-resumable error is rejected before provider side effects.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Anthony Kim (anthonykim1)
approved these changes
Aug 26, 2026
roblourens
added a commit
that referenced
this pull request
Aug 28, 2026
* Revert "agentHost: temporarily disable retryable errors" Reverts #332839 now that the retry issue is fixed. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: preserve non-resumable error handling Keep subagent errors non-resumable when their parent mapping is missing, and retain dispatcher coverage for rejecting non-resumable retry requests. (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporarily stops marking Copilot errors as resumable, which prevents clients from offering or dispatching in-place retries. The retry protocol, reducer, and provider resume implementation remain intact so the feature can be re-enabled by restoring the flags.
Retry-specific E2E scenarios are skipped and documented while the feature is disabled. Unit and E2E expectations now verify that live, restored, interrupted, and repeated errors omit
resumable.Validation
npm run transpile-client./scripts/test.sh --run src/vs/platform/agentHost/test/node/copilotAgentSession.test.ts --run src/vs/platform/agentHost/test/node/mapSessionEvents.test.ts --run src/vs/platform/agentHost/test/node/agentService.test.ts./scripts/test.sh --run src/vs/platform/agentHost/test/node/copilotAgentSession.test.ts./scripts/test-integration.sh --run src/vs/platform/agentHost/test/node/e2e/providers/copilotAgentHostE2E.integrationTest.ts --grep "request error survives a host restart"(Written by Copilot)