Preserve visible dictation transcript after stop - #332970
Merged
Merged
Conversation
Fixes #332324 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Preserves visible dictation text when the backend’s final hypothesis would remove or rewrite it.
Changes:
- Adds final-transcript selection logic.
- Enables preservation for live-rendered dictation.
- Adds selection behavior tests.
Show a summary per file
| File | Description |
|---|---|
chatSpeechToTextService.ts |
Adds preservation options and transcript selection. |
dictationSession.ts |
Requests preservation for visible transcripts. |
chatSpeechToTextService.test.ts |
Tests final transcript selection cases. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Balanced
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Ben Villalobos (benvillalobos)
approved these changes
Aug 27, 2026
Raymond Zhao (rzhao271)
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #332324
Validation
npm run compile./scripts/test.sh --run src/vs/workbench/contrib/chat/test/browser/chatSpeechToTextService.test.ts --run src/vs/workbench/contrib/chat/test/browser/dictationSession.test.ts(23 passing)