terminal: avoid shell integration command delay - #332981
Merged
Connor Peet (connor4312) merged 2 commits intoAug 27, 2026
Merged
Conversation
Fix a race that delayed commands when command detection was ready before the shell prompt entered its input state. - Wait for input on an existing command detection capability. - Continue to wait for capability registration when none exists. - Add a regression test for the shell integration event order. Fixes microsoft#277391 Fixes microsoft#329895 (Commit message generated by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Anthony Kim (@anthonykim1)Matched files:
|
Anthony Kim (anthonykim1)
approved these changes
Aug 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a shell-integration race that delayed terminal commands until timeout.
Changes:
- Waits on existing command detection capabilities.
- Retains capability-registration waiting when absent.
- Adds regression coverage for OSC 633
A→ command →Bordering.
Show a summary per file
| File | Description |
|---|---|
terminalInstance.ts |
Corrects prompt-input waiting logic. |
terminalInstance.test.ts |
Tests the fast shell initialization race. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
terminal: avoid shell integration command delay
Fix a race that delayed commands when command detection was ready before
the shell prompt entered its input state.
Fixes #277391
Fixes #329895
(Commit message generated by Copilot)
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com