Fix smoke test flake in Quick Outline - #333094
Merged
Joaquín Ruales (jruales) merged 1 commit intoAug 28, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
Review tier: Balanced
Findings: None
What changed in this PR
Restores label-only Quick Outline observation to avoid transient unfocused-row timeouts while preserving strict Command Palette matching.
Changes:
- Reintroduces label-text observation for Quick Input rows.
- Uses it when opening Quick Outline.
| File | Description |
|---|---|
test/automation/src/quickinput.ts |
Adds label-only Quick Input text polling. |
test/automation/src/quickaccess.ts |
Uses label-only polling for Quick Outline retries. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Joaquín Ruales (jruales)
changed the title
Dmitriy Vasyura (dmitrivMS)
approved these changes
Aug 28, 2026
Joaquín Ruales (jruales)
deleted the
jruales/fix-quick-outline-automation
branch
August 28, 2026 06:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
PR #332892 changed
openQuickOutline()to use the focused-row helper introduced for command-ID matching. Quick Outline can transiently show no symbol results without a focused selectable row, causing the Web Language Features smoke test to time out before its existing retry logic can observeNo symbol information for the file.This restores the previous label-only observation for Quick Outline while retaining strict focused label/ID matching in
runCommand().Validation
npm --prefix test/automation run compilenpm run eslint -- test/automation/src/quickaccess.ts test/automation/src/quickinput.tsgit diff --check