Agents - fix race condition around changeset subscriptions - #333110
Merged
Conversation
Ladislau Szomoru (lszomoru)
enabled auto-merge (squash)
August 28, 2026 06:31
Copilot started reviewing on behalf of
Ladislau Szomoru (lszomoru)
August 28, 2026 06:32
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
Review tier: Balanced
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
src/vs/platform/agentHost/node/agentHostChangesetService.ts — After making the recompute unconditional, _pendingMaterialization is no longer read anywhere: all… |
What changed in this PR
Fixes a race where changeset subscriptions could miss recomputation during session materialization.
Changes:
- Always recomputes subscribed changesets when a working directory becomes available.
- Adds regression coverage for worktree materialization timing.
| File | Description |
|---|---|
agentHostChangesetService.test.ts |
Adds materialization race regression test. |
agentHostChangesetService.ts |
Makes materialization recomputation unconditional. |
agentHostChangesetService.ts (common) |
Updates the service contract documentation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Ladislau Szomoru (lszomoru)
changed the title
Dmitriy Vasyura (dmitrivMS)
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.