Fix Ctrl+N replacing the current Chat Editor - #333122
Merged
Dmitriy Vasyura (dmitrivMS) merged 2 commits intoAug 28, 2026
Merged
Conversation
Keep the existing chat editor open by limiting the clear-current-chat shortcut to non-editor chat surfaces. Add regression coverage for both chat view and chat editor contexts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dmitriy Vasyura (dmitrivMS)
added
bug
Dmitriy Vasyura (dmitrivMS)
enabled auto-merge (squash)
August 28, 2026 08:03
Copilot started reviewing on behalf of
Dmitriy Vasyura (dmitrivMS)
August 28, 2026 08:04
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
Review tier: Balanced
Findings: None
What changed in this PR
Fixes Ctrl+N handling so a focused Chat Editor opens a separate editor without replacing its current session.
Changes:
- Excludes Chat Editors from the existing “New Chat” keybinding scope.
- Adds regression coverage for Chat view and Chat Editor scopes.
| File | Description |
|---|---|
chatNewActions.ts |
Restricts the clear-chat shortcut to non-editor chat contexts. |
chatNewActions.test.ts |
Verifies Ctrl+N resolves to the appropriate action by context. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Inspect the New Chat action descriptor directly so the regression test does not pollute the command registry and interfere with ChatTipService tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Ladislau Szomoru (lszomoru)
approved these changes
Aug 28, 2026
Dmitriy Vasyura (dmitrivMS)
deleted the
dev/dmitriv/ctrl-n-new-chat-editor
branch
August 28, 2026 09:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #333119