Add show banner - #333195
Merged
Merged
Conversation
Connor Peet (connor4312)
approved these changes
Aug 28, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
Review tier: Balanced
Findings: None
What changed in this PR
Adds showBanner promo metadata so promotions can remain in the model picker without appearing above chat input.
Changes:
- Propagates
showBannerthrough Copilot and Agent Host metadata. - Filters banner-ineligible promotions from chat notifications.
- Adds coverage for banner opt-out behavior.
| File | Description |
|---|---|
src/vscode-dts/vscode.proposed.chatProvider.d.ts |
Exposes the proposed API field. |
src/vs/workbench/contrib/chat/test/browser/chatPromoNotification.test.ts |
Tests banner suppression. |
src/vs/workbench/contrib/chat/common/languageModels.ts |
Defines metadata and eligibility helper. |
src/vs/workbench/contrib/chat/browser/chatPromoNotification.ts |
Applies banner eligibility filtering. |
src/vs/platform/agentHost/common/agentModelPricing.ts |
Normalizes and forwards promo metadata. |
extensions/copilot/src/platform/networking/common/networking.ts |
Extends endpoint promo metadata. |
extensions/copilot/src/platform/endpoint/node/chatEndpoint.ts |
Maps the server field. |
extensions/copilot/src/platform/endpoint/common/endpointProvider.ts |
Defines the server response field. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement #333001