Refine new chat issue/PR pills - #333200
Merged
Megan Rogge (meganrogge) merged 4 commits intoAug 28, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Megan Rogge (meganrogge)
changed the title
Contributor
There was a problem hiding this comment.
Copilot review overview
Review tier: Balanced
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
src/vs/sessions/contrib/chat/browser/sessionWorkspacePicker.ts — The new icon state can remain stale when a GitHub attachment is introduced by synchronizing the… |
What changed in this PR
Refines new-chat workspace pills by hiding the add icon after GitHub context is attached and reducing pill height.
Changes:
- Adds conditional icon visibility for attached context.
- Restores the icon after attachments are cleared.
- Reduces category pill height and updates tests.
| File | Description |
|---|---|
sessionWorkspacePicker.test.ts |
Tests attached and cleared icon states. |
sessionWorkspacePicker.ts |
Adds conditional trigger-icon rendering. |
newChatWidget.ts |
Enables icon hiding for Issue/PR. |
chatWidget.css |
Reduces category pill height. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Screenshot ChangesBase: Changed (29)
|
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionDefault/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionWorkspacePicker/Dark
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionWorkspacePicker/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionGitHubContextPicker/Dark
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionGitHubContextPicker/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionAttachedContext/Dark
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionAttachedContext/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionRemoteWorkspace/Dark
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionRemoteWorkspace/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionNarrow/Dark
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionNarrow/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionComments/Dark
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionComments/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionTip/Dark
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionTip/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/PromptOptionsLoading/Dark
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/PromptOptionsLoading/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/PromptOptionsStandard/Dark
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/PromptOptionsStandard/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/PromptOptionsGitHubMixed/Dark
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/PromptOptionsGitHubMixed/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/PromptOptionsSelected/Dark
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/PromptOptionsSelected/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/PromptOptionsEditedDisabled/Dark
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/PromptOptionsEditedDisabled/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/PromptOptionsNarrow/Dark
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/PromptOptionsNarrow/Light
| Before | After |
|---|---|
 |
 |
chat/aiCustomizations/aiCustomizationManagementEditor/McpServersSearch/Dark
| Before | After |
|---|---|
 |
 |
Refresh the 8 blocks-ci screenshot hashes affected by reducing the Agents Window new-chat category pill height from 32px to 24px and hiding the Issue/PR pill plus icon once an item is attached. Hashes copied from CI run 33191423140 job 98917675161 (ubuntu-latest); not regenerated locally. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
3 tasks
Aaron Munger (amunger)
approved these changes
Aug 28, 2026
Megan Rogge (meganrogge)
deleted the
agents/remove-plus-from-agents-pill
branch
August 28, 2026 18:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
npm run transpile-clientnpm run stylelint -- src/vs/sessions/contrib/chat/browser/media/chatWidget.css./scripts/test.sh --run src/vs/sessions/contrib/chat/test/browser/sessionWorkspacePicker.test.ts --grep "keeps a folder selected and counts multiple GitHub context attachments"