sessions: Fix gaps in nested chat hierarchy guides - #333741
Merged
Sandeep Somavarapu (sandy081) merged 2 commits intoSep 1, 2026
Merged
Conversation
Extend continuing hierarchy guides through the inset row spacing while preserving the final child connector. Add a blocking component fixture for the hover-revealed guide in dark and light themes.\n\nFixes #333487\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sandeep Somavarapu (sandy081)
enabled auto-merge (squash)
September 1, 2026 09:29
Copilot started reviewing on behalf of
Sandeep Somavarapu (sandy081)
September 1, 2026 09:29
View session
Dirk Bäumer (dbaeumer)
previously approved these changes
Sep 1, 2026
Contributor
There was a problem hiding this comment.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Note
This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.
Contributor
Screenshot ChangesBase: Changed (16)
|
| Before | After |
|---|---|
 |
 |
sessions/blockedSessionsList/BlockedSessionsList_SingleNeedsInput/Light
| Before | After |
|---|---|
 |
 |
sessions/blockedSessionsList/BlockedSessionsList_TwoApprovals/Dark
| Before | After |
|---|---|
 |
 |
sessions/blockedSessionsList/BlockedSessionsList_TwoApprovals/Light
| Before | After |
|---|---|
 |
 |
sessions/blockedSessionsList/BlockedSessionsList_FiveApprovals/Dark
| Before | After |
|---|---|
 |
 |
sessions/blockedSessionsList/BlockedSessionsList_FiveApprovals/Light
| Before | After |
|---|---|
 |
 |
sessions/blockedSessionsList/BlockedSessionsList_FixCIAndApproval/Dark
| Before | After |
|---|---|
 |
 |
sessions/blockedSessionsList/BlockedSessionsList_FixCIAndApproval/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_CustomGroup_LongWorkspaceNarrow/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_CustomGroup_LongWorkspaceNarrow/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_CustomGroup_Phone/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_CustomGroup_Phone/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_NestedChatApprovals/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_NestedChatApprovals/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_NestedChatApprovals_Phone/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_NestedChatApprovals_Phone/Light
| Before | After |
|---|---|
 |
 |
Added (2)
sessions/sessionsList/SessionsList_NestedChatHierarchyGuides/Dark
sessions/sessionsList/SessionsList_NestedChatHierarchyGuides/Light
Record the Ubuntu-rendered dark and light hashes for the new blocking hierarchy-guide fixture. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dirk Bäumer (dbaeumer)
approved these changes
Sep 1, 2026
Sandeep Somavarapu (sandy081)
deleted the
sandy081/agents/fix-vscode-issue-333487-chat-rendering
branch
September 1, 2026 10:36
Bhavya U (bhavyaus)
pushed a commit
that referenced
this pull request
Sep 1, 2026
* sessions: Fix gaps in nested chat hierarchy guides Extend continuing hierarchy guides through the inset row spacing while preserving the final child connector. Add a blocking component fixture for the hover-revealed guide in dark and light themes.\n\nFixes #333487\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * sessions: Add nested chat hierarchy screenshot baselines Record the Ubuntu-rendered dark and light hashes for the new blocking hierarchy-guide fixture. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #333487
Extends the parent and intermediate nested-chat hierarchy guides through the inset row spacing so the navigation line remains continuous. The final child keeps its existing L-shaped connector, and the expand/collapse twistie alignment is unchanged.
Adds a blocking component screenshot fixture that reveals the hierarchy guides through the real hover behavior and validates both dark and light themes.
Validation:
npm run compilenpm run hygiene