Add agents window capability - #333744
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
Review tier: Balanced
Findings: 2
New issues introduced by this change (2)
| Severity | Finding |
|---|---|
 |
src/vs/workbench/services/extensions/common/extensionManifestPropertiesService.ts — Executable extensions opted in here are still discarded from Agents-window Marketplace results… |
|
src/vs/workbench/services/extensions/common/extensionManifestPropertiesService.ts — supported: false is not honored for built-in extensions. _isDisabledBySessionsWindow returns… |
What changed in this PR
Adds a proposed extension capability for declaring Agents window support.
Changes:
- Registers
agentsWindowActivationproposal and manifest schema. - Uses the capability when determining extension enablement.
- Adds enablement and manifest-property tests.
| File | Description |
|---|---|
vscode.proposed.agentsWindowActivation.d.ts |
Adds proposal placeholder. |
extensionManifestPropertiesService.test.ts |
Tests capability handling. |
extensionsRegistry.ts |
Defines the manifest schema. |
extensionManifestPropertiesService.ts |
Applies declared support. |
extensionEnablementService.test.ts |
Tests Agents window enablement. |
extensionsApiProposals.ts |
Registers the proposal. |
extensions.ts |
Adds the capability type. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Dirk Bäumer (dbaeumer)
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.