agentHost: hide picker-disabled Codex models - #333756
Merged
Giuseppe Cianci (Giuspepe) merged 3 commits intoSep 1, 2026
Merged
Conversation
Require Copilot models to be both picker-enabled and compatible with the Responses endpoint before advertising them through the Codex harness.\n\nFixes #331355
Copilot started reviewing on behalf of
Giuseppe Cianci (Giuspepe)
September 1, 2026 12:00
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
Review tier: Balanced
Findings: None
What changed in this PR
Filters Codex’s Copilot model catalog so only picker-enabled, Responses-compatible models are published.
Changes:
- Require
model_picker_enabledduring Codex model filtering. - Add regression coverage and update model fixtures.
| File | Description |
|---|---|
src/vs/platform/agentHost/node/codex/codexAgent.ts |
Filters picker-disabled models. |
src/vs/platform/agentHost/test/node/codex/codexModelRefresh.test.ts |
Adds regression coverage and updates fixtures. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Keep the shared create-chat and prewarm fixtures eligible under the production model filter.
Giuseppe Cianci (Giuspepe)
marked this pull request as ready for review
September 1, 2026 13:19
Giuseppe Cianci (Giuspepe)
enabled auto-merge (squash)
September 1, 2026 13:19
Martin Aeschlimann (aeschli)
approved these changes
Sep 1, 2026
Ladislau Szomoru (lszomoru)
approved these changes
Sep 1, 2026
Giuseppe Cianci (Giuspepe)
deleted the
agents/debug-fix-issue-331355-vscode
branch
September 1, 2026 13:43
Bhavya U (bhavyaus)
pushed a commit
that referenced
this pull request
Sep 1, 2026
* agentHost: hide picker-disabled Codex models Require Copilot models to be both picker-enabled and compatible with the Responses endpoint before advertising them through the Codex harness.\n\nFixes #331355 * agentHost: mark Codex test models picker-enabled Keep the shared create-chat and prewarm fixtures eligible under the production model filter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #331355
The Copilot model catalog can include models that support the Responses endpoint but are disabled for model pickers. Codex was publishing all Responses-compatible entries, which exposed those models in the Codex picker.
This change requires Copilot models to be both picker-enabled and Responses-compatible before publishing them through Codex. It also adds regression coverage for excluding picker-disabled models and keeps shared Codex test models explicitly picker-enabled.
Validation: