sessions: Count blocked sessions in application badge - #333774
Merged
Benjamin Christopher Simmonds (benibenj) merged 2 commits intoSep 1, 2026
Merged
Conversation
Include sessions that need input or have failing pull request CI, while excluding unread sessions that are still in progress. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Benjamin Christopher Simmonds (benibenj)
enabled auto-merge (squash)
September 1, 2026 14:51
Copilot started reviewing on behalf of
Benjamin Christopher Simmonds (benibenj)
September 1, 2026 14:52
View session
Ladislau Szomoru (lszomoru)
previously approved these changes
Sep 1, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
Review tier: Balanced
Findings: 2
New issues introduced by this change (2)
| Severity | Finding |
|---|---|
 |
src/vs/sessions/contrib/sessions/electron-browser/sessions.contribution.ts — The criteria here no longer match the implementation: archived sessions are always excluded, and… |
|
src/vs/sessions/contrib/sessions/electron-browser/sessionsApplicationBadge.ts — This class documentation now omits filtering that the implementation applies: archived sessions are… |
What changed in this PR
Updates the application badge to reflect sessions requiring attention.
Changes:
- Counts blocked sessions and excludes unread in-progress sessions.
- Reuses
BlockedSessionsfor failing CI detection. - Adds focused regression tests and updates setting text.
| File | Description |
|---|---|
sessionsApplicationBadge.ts |
Revises badge counting logic. |
sessionsApplicationBadge.test.ts |
Adds blocked-session regression coverage. |
sessions.contribution.ts |
Updates the setting description. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Document the archived, in-progress, pull request state, and draft filters applied by the badge count. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Ladislau Szomoru (lszomoru)
approved these changes
Sep 1, 2026
Benjamin Christopher Simmonds (benibenj)
merged commit Sep 1, 2026
0ff22af
into
main
40 checks passed
Benjamin Christopher Simmonds (benibenj)
deleted the
benibenj/agents/count-sessions-with-input-and-ci-failures
branch
September 1, 2026 15:22
Bhavya U (bhavyaus)
pushed a commit
that referenced
this pull request
Sep 1, 2026
* sessions: Count blocked sessions in application badge Include sessions that need input or have failing pull request CI, while excluding unread sessions that are still in progress. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * sessions: Clarify application badge criteria Document the archived, in-progress, pull request state, and draft filters applied by the badge count. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
npm run transpile-clientnpm run typecheck-clientnpm run valid-layers-check.\scripts\test.bat --run src\vs\sessions\contrib\sessions\test\electron-browser\sessionsApplicationBadge.test.tsFull
npm run hygieneis blocked on Windows by an existing path resolution issue that looks forC:\C:\...\remote\package.json; scoped pre-commit hygiene passed.