Prevent hidden chats from rendering during custom view swaps - #333789
Merged
Benjamin Christopher Simmonds (benibenj) merged 1 commit intoSep 1, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Benjamin Christopher Simmonds (benibenj)
enabled auto-merge (squash)
September 1, 2026 15:40
Copilot started reviewing on behalf of
Benjamin Christopher Simmonds (benibenj)
September 1, 2026 15:40
View session
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Sandeep Somavarapu (@sandy081)Matched files:
Ladislau Szomoru (@lszomoru)Matched files:
|
Contributor
There was a problem hiding this comment.
Copilot review overview
Review tier: Balanced
Findings: 2
New issues introduced by this change (2)
| Severity | Finding |
|---|---|
 |
src/vs/sessions/browser/workbench.ts — Suspend the session content before unmaximizing the editor. setEditorMaximized(false) restores… |
|
src/vs/sessions/browser/workbench.ts — Resume the chats only after removing the hidden layout classes. While closing a custom view,… |
What changed in this PR
Prevents hidden Sessions chats from laying out during custom-view transitions.
Changes:
- Adds an independent session-content visibility gate.
- Defers hidden chat layouts and catches up when shown.
- Adds transition, startup, and hidden-layout tests.
| File | Description |
|---|---|
src/vs/sessions/browser/workbench.ts |
Suspends chat content during custom-view transitions. |
src/vs/sessions/browser/parts/sessionsPart.ts |
Combines grid and content visibility. |
src/vs/sessions/browser/parts/sessionsParts.ts |
Forwards content visibility changes. |
src/vs/sessions/browser/parts/chatGroupView.ts |
Skips hidden child layouts. |
src/vs/sessions/services/sessions/browser/sessionsPartService.ts |
Exposes content visibility control. |
src/vs/sessions/test/browser/workbench.test.ts |
Tests transition ordering and startup. |
src/vs/sessions/test/browser/sessionsPart.test.ts |
Tests combined visibility state. |
src/vs/sessions/test/browser/chatGroupsView.test.ts |
Tests hidden layout suppression. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| } | ||
|
|
||
| // Suspend chat content before any custom view transition can trigger layout. | ||
| this.sessionsPartService.setContentVisible(false); |
| } | ||
| }); | ||
| } finally { | ||
| this.sessionsPartService.setContentVisible(!visible); |
Contributor
Screenshot ChangesBase: Changed (1)
|
| Before | After |
|---|---|
 |
 |
1 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details.
Sandeep Somavarapu (sandy081)
approved these changes
Sep 1, 2026
Benjamin Christopher Simmonds (benibenj)
merged commit Sep 1, 2026
959f7db
into
main
41 checks passed
Benjamin Christopher Simmonds (benibenj)
deleted the
benibenj/fix-automation-chat-freeze
branch
September 1, 2026 16:08
Bhavya U (bhavyaus)
pushed a commit
that referenced
this pull request
Sep 1, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #333294
Validation