Allow semantic search toggle for search subagent - #333869
Merged
Merged
Conversation
Copilot started reviewing on behalf of
Anisha Agarwal (24anisha)
September 1, 2026 21:21
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The public setting name should be corrected before release, and the test should use typed dependency injection.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 2
New issues introduced by this change (2)
| Severity | Finding |
|---|---|
 |
extensions/copilot/package.json — Rename this setting before it becomes a public configuration API. The searchSubagent scope… |
|
extensions/copilot/src/extension/prompt/test/node/searchSubagentToolCallingLoop.spec.ts — Inject a typed IToolsService test double into serviceCollection before creating the accessor… |
What changed in this PR
Adds an experimental toggle controlling semantic search availability within the Search subagent.
Changes:
- Adds a default-enabled configuration setting.
- Filters semantic search from subagent tools when disabled.
- Adds localization and unit coverage.
| File | Description |
|---|---|
configurationService.ts |
Defines the experiment-based setting. |
searchSubagentToolCallingLoop.ts |
Conditionally enables semantic search. |
searchSubagentToolCallingLoop.spec.ts |
Tests enabled and disabled behavior. |
package.nls.json |
Adds the setting description. |
package.json |
Contributes the public setting. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Bhavya U (bhavyaus)
approved these changes
Sep 2, 2026
Anisha Agarwal (24anisha)
enabled auto-merge
September 2, 2026 19:26
SteVen Batten (sbatten)
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to detected potential unreliability with the semantic search tool, we gate the availability of semantic search only for the Search subagent behind a feature flag.
Default behavior always makes semantic search available.