agentHost: preserve search icon while streaming - #333925
Merged
roblourens merged 1 commit intoSep 2, 2026
Merged
Conversation
Initialize search-specific rendering data when a streaming tool invocation is created so text searches do not briefly use the generic tool icon. Add regression coverage for rg calls before they become ready.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused lifecycle fix is consistent with existing ready and completed search handling and has direct regression coverage.
Review tier: Balanced
Findings: None
What changed in this PR
Preserves search-specific rendering during Agent Host tool-call streaming, preventing temporary generic tool icons.
Changes:
- Assigns search tool metadata when creating streaming invocations.
- Adds regression coverage for streaming
rgsearches.
| File | Description |
|---|---|
stateToProgressAdapter.ts |
Initializes streaming searches with search-specific rendering data. |
stateToProgressAdapter.test.ts |
Verifies search metadata is preserved before readiness. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Vijay Upadya (vijayupadya)
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rgtext searches from briefly showing the generic tool codicon before becoming readyTesting
npm run transpile-clientnpm run eslint -- src/vs/workbench/contrib/chat/browser/agentSessions/agentHost/stateToProgressAdapter.ts src/vs/workbench/contrib/chat/test/browser/agentSessions/stateToProgressAdapter.test.ts./scripts/test.sh --run src/vs/workbench/contrib/chat/test/browser/agentSessions/stateToProgressAdapter.test.ts(144 passing)(Written by Copilot)