Add ready message when creating from PR - #333968
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Failed or cancelled bootstrap requests currently produce a misleading success message.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
src/vs/sessions/contrib/chat/browser/chatView.ts — hiddenRequestIncomplete === false means only that the response reached any terminal state.… |
What changed in this PR
Adds a completion message confirming when a pull-request session is ready.
Changes:
- Persists an optional transcript-context ready message.
- Displays completed preparation with a checkmark.
- Adds PR-specific messaging and regression tests.
| File | Description |
|---|---|
chatVariableEntries.ts |
Persists ready messages. |
chatWidget.ts |
Renders completed transcript progress. |
stateToProgressAdapter.test.ts |
Tests metadata restoration. |
pullRequestPicker.ts |
Defines the PR-ready message. |
pullRequestPicker.test.ts |
Tests PR attachment output. |
chatView.ts |
Selects pending or completed progress. |
chatView.test.ts |
Tests completion visibility. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Alex Ross (alexr00)
marked this pull request as draft
September 2, 2026 10:54
auto-merge was automatically disabled
September 2, 2026 10:54
Pull request was converted to draft
Alex Ross (alexr00)
marked this pull request as ready for review
September 2, 2026 11:14
Alex Ross (alexr00)
enabled auto-merge (squash)
September 2, 2026 11:14
Sandeep Somavarapu (sandy081)
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #331194