Fix agent session status alignment - #334083
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Megan Rogge (meganrogge)
September 2, 2026 18:45
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused CSS change correctly fixes alignment without affecting spinner rendering.
Review tier: Balanced
Findings: None
What changed in this PR
Centers session and chat rich-link status codicons while preserving spinner layout.
Changes:
- Applies inline-flex centering to trailing status codicons.
| File | Description |
|---|---|
chatRichLink.css |
Centers session/chat status icons. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Megan Rogge (meganrogge)
enabled auto-merge (squash)
September 2, 2026 19:06
Contributor
Screenshot ChangesBase: Changed (4)
|
| Before | After |
|---|---|
 |
 |
chat/chatRichLink/inChat/Light
| Before | After |
|---|---|
 |
 |
chat/chatRichLink/sessionStates/Dark
| Before | After |
|---|---|
 |
 |
chat/chatRichLink/sessionStates/Light
| Before | After |
|---|---|
 |
 |
1 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details.
Dmitriy Vasyura (dmitrivMS)
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #333486
The global rendered-markdown codicon rule shifts icons down to align them with surrounding text. Rich links already manage their own icon alignment, but only the leading icon had its offset reset. This change also resets the trailing status icon, including while an agent chat link is temporarily rendered as a generic loading resource, and adds both in-progress chat and loading states to the existing rich-link component fixture.
Testing
npm run stylelint -- src/vs/workbench/contrib/chat/browser/widget/chatContentParts/media/chatRichLink.css./scripts/test.sh --run src/vs/workbench/contrib/chat/test/browser/widget/chatContentParts/chatRichLink.test.ts