chat: Match request origin hover terminology - #334085
Merged
Merged
Conversation
Use session terminology for session-scoped delegation hovers while preserving chat terminology for chat and legacy origins. Add regression coverage for both scopes.\n\nFixes #333482\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Megan Rogge (meganrogge)
enabled auto-merge (squash)
September 2, 2026 18:48
Copilot started reviewing on behalf of
Megan Rogge (meganrogge)
September 2, 2026 18:48
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation matches the issue and includes focused regression coverage.
Review tier: Balanced
Findings: None
What changed in this PR
Aligns request-origin hover terminology with delegation scope, fixing #333482.
Changes:
- Uses “Open source session” for session-scoped origins.
- Preserves “Open source chat” for chat and legacy origins.
- Adds regression coverage for both explicit scopes.
| File | Description |
|---|---|
chatRequestOriginPart.ts |
Selects hover text by delegation scope. |
chatRequestOriginPart.test.ts |
Verifies chat- and session-scoped labels and hovers. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Dmitriy Vasyura (dmitrivMS)
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #333482
Validation
npm run transpile-client./scripts/test.sh --run src/vs/workbench/contrib/chat/test/browser/widget/chatContentParts/chatRequestOriginPart.test.tsnpm run eslint -- src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatRequestOriginPart.ts src/vs/workbench/contrib/chat/test/browser/widget/chatContentParts/chatRequestOriginPart.test.tsnpm run hygiene