launch: Show agent session in editor window title - #334108
Merged
Megan Rogge (meganrogge) merged 3 commits intoSep 2, 2026
Merged
Conversation
Identify isolated Code OSS editor windows by placing the originating agent session title first in window.title. Preserve JSONC settings and keep copied symlinked settings isolated from the source profile.\n\nFixes #334097\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Megan Rogge (meganrogge)
September 2, 2026 20:32
View session
Megan Rogge (meganrogge)
enabled auto-merge (squash)
September 2, 2026 20:34
Dmitriy Vasyura (dmitrivMS)
previously approved these changes
Sep 2, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Relative settings symlinks and duplicate JSONC properties can prevent the intended settings from taking effect.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 3
New issues introduced by this change (3)
| Severity | Finding |
|---|---|
 |
.agents/skills/launch/scripts/launch.sh — With set -u, invoking launch.sh --session-title without a value expands an unset $2 and exits… |
|
.agents/skills/launch/scripts/updateSettings.ts — A copied relative symlink can be dangling at this point. rsync -a preserves User/settings.json… |
|
.agents/skills/launch/scripts/updateSettings.ts — This updates only the first occurrence of a root setting. VS Code's JSON parser assigns properties… |
What changed in this PR
Adds stable session-first titles to isolated editor windows launched from agent sessions.
Changes:
- Adds cross-platform
--session-titlesupport. - Updates isolated JSONC settings while breaking settings symlinks.
- Documents usage and Agents-window restrictions.
| File | Description |
|---|---|
.agents/skills/launch/SKILL.md |
Documents session-title launching. |
.agents/skills/launch/scripts/updateSettings.ts |
Updates isolated JSONC settings. |
.agents/skills/launch/scripts/launch.sh |
Adds Bash option handling. |
.agents/skills/launch/scripts/launch.ps1 |
Adds PowerShell option handling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Validate missing Bash option values, dereference relative settings symlinks from the source profile, and update the last duplicate root setting so the effective JSONC value changes.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
roblourens
approved these changes
Sep 2, 2026
Megan Rogge (meganrogge)
deleted the
agents/vscode-issue-334097-implementation
branch
September 2, 2026 21:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--session-title--session-titlefor standalone Agents windows, wherewindow.titleis read-onlyThis is a stable, session-first alternative to #334104. Unlike that PR, it intentionally omits the active editor title (
Welcomeor a filename), so the identifying title does not change while navigating editors. It also does not add a fallback launch identifier when no session title is provided.Fixes #334097
Validation
npm run compilenpm run eslint -- .agents/skills/launch/scripts/updateSettings.tsShow originating session — vscode-issue-334097-implementation — Code - OSS DevThe repository hygiene runner has no eligible paths under
.agents/skills/launch; invoking it with the changed files reports that no hygiene-eligible files matched.