agentHost: Re-enable Copilot process log exports - #334175
Merged
Merged
Conversation
The current Copilot runtime includes the debug-log collection performance improvements, so include process logs again for both session-scoped and host-wide exports.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused implementation and tests correctly match the stated export behavior.
Review tier: Balanced
Findings: None
What changed in this PR
Re-enables Copilot SDK process logs in Agent Host debug exports while preserving session scoping.
Changes:
- Enables process-log collection for all Copilot debug exports.
- Updates focused unit-test expectations.
| File | Description |
|---|---|
copilotAgentSession.ts |
Includes SDK process logs in exports. |
copilotAgentSession.test.ts |
Verifies session and host-wide inclusion settings. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Screenshot ChangesBase: Errored (8)Fixtures that failed to render — no screenshot was produced.
|
roblourens
marked this pull request as ready for review
September 3, 2026 16:08
Henning Dieterichs (hediet)
approved these changes
Sep 3, 2026
Henning Dieterichs (hediet)
left a comment
Henning Dieterichs (hediet)
left a comment
Member
There was a problem hiding this comment.
Approved after current-head Copilot Code Review and GPT Luna found no security issue in the full PR patch.
roblourens
deleted the
roblou/agents/export-agent-logs-reenable-check
branch
September 3, 2026 16:18
Henning Dieterichs (hediet)
approved these changes
Sep 3, 2026
Henning Dieterichs (hediet)
left a comment
Henning Dieterichs (hediet)
left a comment
Member
There was a problem hiding this comment.
Approved after manual review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The Copilot runtime now includes the debug-log collection performance improvements from github/copilot-agent-runtime#15407, so the temporary process-log exclusion is no longer needed.
Validation
npm run transpile-client./scripts/test.sh --run src/vs/platform/agentHost/test/node/copilotAgentSession.test.ts --grep "collects SDK debug logs with process logs"npm run eslint -- src/vs/platform/agentHost/node/copilot/copilotAgentSession.ts src/vs/platform/agentHost/test/node/copilotAgentSession.test.ts(Written by Copilot)