Send language ID for read file telemetry - #334231
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Error telemetry omits the language ID even when a document snapshot was successfully created.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
extensions/copilot/src/extension/tools/node/readFileTool.tsx — languageId is only populated on the success path. If snapshot creation succeeds but a later… |
What changed in this PR
Adds document language IDs to read-file and region-adjustment telemetry.
Changes:
- Adds
languageIdto three telemetry event schemas and payloads. - Passes document snapshots into region telemetry helpers.
| File | Description |
|---|---|
extensions/copilot/src/extension/tools/node/readFileTool.tsx |
Enriches read-file telemetry with snapshot language IDs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Screenshot ChangesBase: 1 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details. Errored (8)Fixtures that failed to render — no screenshot was produced.
|
Ladislau Szomoru (lszomoru)
approved these changes
Sep 3, 2026
Dirk Bäumer (dbaeumer)
deleted the
dbaeumer/tall-kingfisher-turquoise
branch
September 3, 2026 11:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance telemetry by including the language ID of the document snapshot in various telemetry events related to file reading and region adjustments. This change improves the granularity of telemetry data collected for better insights.