Simplify transition effects for chat agent merge twistie - #334235
Merged
Conversation
Lee Murray (mrleemurray)
enabled auto-merge (squash)
September 3, 2026 11:30
Copilot started reviewing on behalf of
Lee Murray (mrleemurray)
September 3, 2026 11:31
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused CSS change is consistent with the stated purpose and preserves reduced-motion handling.
Pull request overview
Simplifies the Agent Merge twistie animation while preserving expansion feedback and reduced-motion behavior.
Changes:
- Removes opacity transitions and conditional visibility.
- Retains the rotation transition for expansion state.
File summaries
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/media/chatAgentMergeContent.css |
Makes the twistie persistently visible and transition only its rotation. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Ladislau Szomoru (lszomoru)
approved these changes
Sep 3, 2026
Contributor
Screenshot ChangesBase: Changed (31)
|
| Before | After |
|---|---|
 |
 |
chat/chatAgentMerge/Comments/Light
| Before | After |
|---|---|
 |
 |
chat/chatAgentMerge/SingleComment/Dark
| Before | After |
|---|---|
 |
 |
chat/chatAgentMerge/SingleComment/Light
| Before | After |
|---|---|
 |
 |
chat/chatAgentMerge/FailingChecks/Dark
| Before | After |
|---|---|
 |
 |
chat/chatAgentMerge/FailingChecks/Light
| Before | After |
|---|---|
 |
 |
chat/chatAgentMerge/FailingChecks/DarkHighContrast
| Before | After |
|---|---|
 |
 |
chat/chatAgentMerge/CommentsAndFailingChecks/Dark
| Before | After |
|---|---|
 |
 |
chat/chatAgentMerge/CommentsAndFailingChecks/Light
| Before | After |
|---|---|
 |
 |
chat/chatAgentMerge/Conflicting/Dark
| Before | After |
|---|---|
 |
 |
chat/chatAgentMerge/Conflicting/Light
| Before | After |
|---|---|
 |
 |
chat/chatAgentMerge/BehindBase/Dark
| Before | After |
|---|---|
 |
 |
chat/chatAgentMerge/BehindBase/Light
| Before | After |
|---|---|
 |
 |
chat/chatAgentMerge/Expanded/Dark
| Before | After |
|---|---|
 |
 |
chat/chatAgentMerge/Expanded/Light
| Before | After |
|---|---|
 |
 |
chat/chatAgentMerge/ExpandedWithReviewSummary/Dark
| Before | After |
|---|---|
 |
 |
chat/chatAgentMerge/ExpandedWithReviewSummary/Light
| Before | After |
|---|---|
 |
 |
chat/chatAgentMerge/ExpandedAgentMessage/Dark
| Before | After |
|---|---|
 |
 |
chat/chatAgentMerge/ExpandedAgentMessage/Light
| Before | After |
|---|---|
 |
 |
chat/chatAgentMerge/ExpandedDuplicateFileNames/Dark
| Before | After |
|---|---|
 |
 |
chat/chatAgentMerge/ExpandedDuplicateFileNames/Light
| Before | After |
|---|---|
 |
 |
chat/chatAgentMerge/ExpandedMarkdownComment/Dark
| Before | After |
|---|---|
 |
 |
chat/chatAgentMerge/ExpandedMarkdownComment/Light
| Before | After |
|---|---|
 |
 |
chat/chatAgentMerge/ExpandedWithLinkedComments/Dark
| Before | After |
|---|---|
 |
 |
chat/chatAgentMerge/ExpandedWithLinkedComments/Light
| Before | After |
|---|---|
 |
 |
chat/chatAgentMerge/InChat/Dark
| Before | After |
|---|---|
 |
 |
chat/chatAgentMerge/InChat/Light
| Before | After |
|---|---|
 |
 |
chat/chatAgentMergeFlow/FullConversation/Dark
| Before | After |
|---|---|
 |
 |
chat/chatAgentMergeFlow/FullConversation/Light
| Before | After |
|---|---|
 |
 |
chat/chatAgentMergeFlow/FullConversationMergedNoticeHovered/Dark
| Before | After |
|---|---|
 |
 |
chat/chatAgentMergeFlow/FullConversationMergedNoticeHovered/Light
| Before | After |
|---|---|
 |
 |
Errored (8)
Fixtures that failed to render — no screenshot was produced.
sessions/remoteHostUnavailable/remoteHostUnavailableEmptyState/HostNotRunning/Dark — unknown error (no image hash produced)
unknown error (no image hash produced)
sessions/remoteHostUnavailable/remoteHostUnavailableEmptyState/HostNotRunning/Light — unknown error (no image hash produced)
unknown error (no image hash produced)
sessions/remoteHostUnavailable/remoteHostUnavailableEmptyState/HostNotRunningAutoStart/Dark — unknown error (no image hash produced)
unknown error (no image hash produced)
sessions/remoteHostUnavailable/remoteHostUnavailableEmptyState/HostNotRunningAutoStart/Light — unknown error (no image hash produced)
unknown error (no image hash produced)
sessions/remoteHostUnavailable/remoteHostUnavailableEmptyState/HostDisconnected/Dark — unknown error (no image hash produced)
unknown error (no image hash produced)
sessions/remoteHostUnavailable/remoteHostUnavailableEmptyState/HostDisconnected/Light — unknown error (no image hash produced)
unknown error (no image hash produced)
sessions/remoteHostUnavailable/remoteHostUnavailableEmptyState/Connecting/Dark — unknown error (no image hash produced)
unknown error (no image hash produced)
sessions/remoteHostUnavailable/remoteHostUnavailableEmptyState/Connecting/Light — unknown error (no image hash produced)
unknown error (no image hash produced)
Benjamin Christopher Simmonds (benibenj)
approved these changes
Sep 3, 2026
Lee Murray (mrleemurray)
deleted the
mrleemurray/busy-tomato-marmoset
branch
September 3, 2026 12:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor transition effects for the chat agent merge twistie to enhance performance and reduce complexity. The opacity transition has been removed, streamlining the visual behavior during interactions. No associated issue. Testing can be done by observing the twistie's behavior during hover and focus events.