sessions: align new chat picker typography - #334307
Merged
Merged
Conversation
Copilot started reviewing on behalf of
Megan Rogge (meganrogge)
September 3, 2026 16:39
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The default non-consolidated tabbed workspace picker does not receive the new icon-sizing class.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
src/vs/sessions/contrib/chat/browser/sessionWorkspacePicker.ts — The new class does not reach the default non-consolidated tabbed workspace picker. When multiple… |
What changed in this PR
Aligns new-session picker typography, icon sizing, spacing, and visual expectations.
Changes:
- Uses body typography and design-system spacing tokens for picker pills.
- Standardizes picker icons and compact chevrons.
- Extends fixture expectations for typography consistency.
| File | Description |
|---|---|
newChatWidget.fixture.ts |
Updates visual expectations. |
sessionWorkspacePicker.ts |
Adds workspace-list styling scope. |
sessionTypePicker.ts |
Adds session-type-list styling scope. |
chatWidget.css |
Aligns typography, icons, and spacing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Henning Dieterichs (hediet)
previously approved these changes
Sep 3, 2026
Henning Dieterichs (hediet)
left a comment
Henning Dieterichs (hediet)
left a comment
Member
There was a problem hiding this comment.
Approved after current-head Copilot Code Review and GPT Luna found no security issue in the full PR patch.
Use consistent body text, base icon sizing, and tokenized spacing across new-session pills and their dropdowns. Fixes #333887. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Megan Rogge (meganrogge)
force-pushed
the
agents/fix-vscode-issue-333887
branch
from
September 3, 2026 16:51
aa91c0a to
08ddb1d
Compare
Megan Rogge (meganrogge)
enabled auto-merge (squash)
September 3, 2026 16:55
Contributor
Screenshot ChangesBase: Changed (34)
|
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionDefault/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionAutoModel/Dark
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionAutoModel/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionCompactAutoModel/Dark
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionCompactAutoModel/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionWorkspacePicker/Dark
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionWorkspacePicker/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionGitHubContextPicker/Dark
| Before | After |
|---|---|
|
|
sessions/chat/newWidget/newChatWidget/NewSessionGitHubContextPicker/Light
| Before | After |
|---|---|
|
|
sessions/chat/newWidget/newChatWidget/NewSessionAttachedContext/Dark
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionAttachedContext/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionPhoneAttachedContext/Dark
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionPhoneAttachedContext/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionRemoteWorkspace/Dark
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionRemoteWorkspace/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionNarrow/Dark
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionNarrow/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionComments/Dark
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionComments/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionTip/Dark
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/NewSessionTip/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/PromptOptionsLoading/Dark
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/PromptOptionsLoading/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/PromptOptionsStandard/Dark
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/PromptOptionsStandard/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/PromptOptionsGitHubMixed/Dark
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/PromptOptionsGitHubMixed/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/PromptOptionsSelected/Dark
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/PromptOptionsSelected/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/PromptOptionsEditedDisabled/Dark
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/PromptOptionsEditedDisabled/Light
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/PromptOptionsNarrow/Dark
| Before | After |
|---|---|
 |
 |
sessions/chat/newWidget/newChatWidget/PromptOptionsNarrow/Light
| Before | After |
|---|---|
 |
 |
Errored (8)
Fixtures that failed to render — no screenshot was produced.
sessions/remoteHostUnavailable/remoteHostUnavailableEmptyState/HostNotRunning/Dark — unknown error (no image hash produced)
unknown error (no image hash produced)
sessions/remoteHostUnavailable/remoteHostUnavailableEmptyState/HostNotRunning/Light — unknown error (no image hash produced)
unknown error (no image hash produced)
sessions/remoteHostUnavailable/remoteHostUnavailableEmptyState/HostNotRunningAutoStart/Dark — unknown error (no image hash produced)
unknown error (no image hash produced)
sessions/remoteHostUnavailable/remoteHostUnavailableEmptyState/HostNotRunningAutoStart/Light — unknown error (no image hash produced)
unknown error (no image hash produced)
sessions/remoteHostUnavailable/remoteHostUnavailableEmptyState/HostDisconnected/Dark — unknown error (no image hash produced)
unknown error (no image hash produced)
sessions/remoteHostUnavailable/remoteHostUnavailableEmptyState/HostDisconnected/Light — unknown error (no image hash produced)
unknown error (no image hash produced)
sessions/remoteHostUnavailable/remoteHostUnavailableEmptyState/Connecting/Dark — unknown error (no image hash produced)
unknown error (no image hash produced)
sessions/remoteHostUnavailable/remoteHostUnavailableEmptyState/Connecting/Light — unknown error (no image hash produced)
unknown error (no image hash produced)
Giuseppe Cianci (Giuspepe)
previously approved these changes
Sep 3, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8d31eaa8-0167-4e21-9b96-54e229afb71e
roblourens
approved these changes
Sep 3, 2026
Martin Aeschlimann (aeschli)
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #333887
Summary
Validation
npm run hygienechatWidget.cssnpm run transpile-clientnpm run compilewas also attempted. The changed Sessions sources compiled, but the command currently fails in the unrelated Markdown editor extension because the installed@vscode/markdown-editorAPI lacksIframeEmbeddedEditorHostTransportandiframeBootstrapUrl.