sessions: Fix duplicate agent mode picker tab stop - #334308
Merged
Megan Rogge (meganrogge) merged 3 commits intoSep 3, 2026
Merged
Conversation
Delegate toolbar focus to the nested sidebar button so the inert action-item wrapper is not exposed as a separate tab stop. Add regression coverage for focus and activation.\n\nFixes #333576\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Megan Rogge (meganrogge)
September 3, 2026 16:39
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused implementation follows established action-view-item patterns and includes appropriate regression coverage.
Review tier: Balanced
Findings: None
What changed in this PR
Fixes the sidebar host picker’s duplicate tab stop by delegating toolbar focus behavior to its nested button.
Changes:
- Delegates focus, blur, and focusability to the picker button.
- Adds browser regression coverage for tab order, focus state, and activation.
| File | Description |
|---|---|
hostFilterActionViewItem.ts |
Corrects sidebar picker focus delegation. |
hostFilterActionViewItem.test.ts |
Tests the corrected keyboard focus behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Henning Dieterichs (hediet)
previously approved these changes
Sep 3, 2026
Henning Dieterichs (hediet)
left a comment
Henning Dieterichs (hediet)
left a comment
Member
There was a problem hiding this comment.
Approved after current-head Copilot Code Review and GPT Luna found no security issue in the full PR patch.
Contributor
Screenshot ChangesBase: 2 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details. Errored (8)Fixtures that failed to render — no screenshot was produced.
|
Keep focus on the Interactive picker trigger instead of exposing its inert toolbar wrapper as a second tab stop. Add regression coverage for the wrapper and trigger focus state.\n\nFixes #333576\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Megan Rogge (meganrogge)
changed the title
Justin Chen (justschen)
previously approved these changes
Sep 3, 2026
Justin Chen (justschen)
left a comment
Justin Chen (justschen)
left a comment
Collaborator
There was a problem hiding this comment.
thanks!
Megan Rogge (meganrogge)
enabled auto-merge (squash)
September 3, 2026 16:58
Henning Dieterichs (hediet)
previously approved these changes
Sep 3, 2026
Henning Dieterichs (hediet)
left a comment
Henning Dieterichs (hediet)
left a comment
Member
There was a problem hiding this comment.
Approved after manual review
Have enum pickers return their trigger directly so the action view item can manage focus without a fragile selector. Preserve the existing wrapper fallback for composite pickers.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Megan Rogge (meganrogge)
dismissed stale reviews from Henning Dieterichs (hediet) and Justin Chen (justschen)
via
September 3, 2026 17:32
1428be8
Ladislau Szomoru (lszomoru)
approved these changes
Sep 3, 2026
Megan Rogge (meganrogge)
deleted the
agents/fix-vscode-issue-333576-ad1e2984
branch
September 3, 2026 18:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #333576
The Agent Host mode picker rendered its own focusable trigger inside a toolbar action item. The wrapper also participated in the toolbar focus model, producing an extra inert tab stop before the working Interactive trigger.
Delegate focus to the picker trigger and keep the wrapper out of the tab order. The regression test verifies that the wrapper is not tabbable, only one descendant is tabbable, and toolbar focus reaches the working trigger.
Testing
npm run hygienenpm run typecheck-clientnpm run transpile-client./scripts/test.sh --run src/vs/sessions/contrib/providers/agentHost/test/browser/agentHost/agentHostSessionConfigPicker.test.tstabIndex=0, its wrapper has notabindex, and it is the only tabbable descendant