agentHost: allow turns with unavailable subagent transcripts - #334312
Merged
roblourens merged 2 commits intoSep 3, 2026
Merged
Conversation
Do not reject a parent turn when restored subagent history is temporarily unavailable during duplicate turn-id validation. Keep the child resolver retryable and preserve strict validation for other peer-chat failures.\n\nAdd unit and whole-host E2E coverage for the recovery path, plus a gated test for the Copilot runtime custom-agent displayName contract mismatch.\n\n(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
(Written by Copilot)\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused exception preserves retryability and fail-closed behavior, with appropriate unit and end-to-end coverage.
Review tier: Balanced
Findings: None
What changed in this PR
Allows parent turns to continue when a restored subagent transcript is temporarily unavailable, while retaining strict handling for other resolution failures.
Changes:
- Introduces a retryable transcript-unavailable error path.
- Adds unit and Copilot end-to-end regression coverage.
- Documents the related runtime contract mismatch.
| File | Description |
|---|---|
agentService.ts |
Skips unavailable subagent transcripts during turn-ID validation. |
agentService.test.ts |
Tests parent dispatch and later transcript retry. |
subagentSuite.ts |
Adds custom-subagent restore scenarios. |
KNOWN_ISSUES.md |
Documents the Copilot runtime mismatch. |
copilotcli-restored-…yaml |
Records the regression scenario’s model exchanges. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Henning Dieterichs (hediet)
approved these changes
Sep 3, 2026
Henning Dieterichs (hediet)
left a comment
Henning Dieterichs (hediet)
left a comment
Member
There was a problem hiding this comment.
Approved after current-head Copilot Code Review and GPT Luna found no security issue in the full PR patch.
Henning Dieterichs (hediet)
approved these changes
Sep 3, 2026
Henning Dieterichs (hediet)
approved these changes
Sep 3, 2026
Henning Dieterichs (hediet)
left a comment
Henning Dieterichs (hediet)
left a comment
Member
There was a problem hiding this comment.
Approved after manual review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
displayName/toolscontract mismatch until the runtime fix is bundledRoot cause
A failed custom subagent left a restored child-chat summary without any child turns. Starting a later parent turn eagerly resolved every peer chat to validate turn-ID uniqueness. The empty child resolver threw, causing the otherwise unrelated parent
chat/turnStartedaction to be rejected before provider dispatch.Validation
npm run typecheck-clientnpm run transpile-client(Written by Copilot)